Changeset 126379 in webkit for trunk/Source/JavaScriptCore/parser/SourceProvider.h

Timestamp:

Aug 22, 2012, 6:33:25 PM (13 years ago)

Author:

[email protected]

Message:

ThreadRestrictionVerifier should be opt-in, not opt-out
​https://bugs.webkit.org/show_bug.cgi?id=94761

Reviewed by Mark Hahnenberg.

../JavaScriptCore:

Removed explicit calls to disable the verifier, since it's off by default now.

• parser/SourceProvider.h:

(JSC::SourceProvider::SourceProvider):
(SourceProvider):

• runtime/SymbolTable.h:

(JSC::SharedSymbolTable::SharedSymbolTable):

../WTF:

WebKit's JavaScript engine supports use on multiple threads, so default-on
is not appropriate for most of our objects, and it causes lots of suprious
assertions.

• wtf/MetaAllocator.cpp:

(WTF::MetaAllocatorHandle::MetaAllocatorHandle): No need to turn off
explicitly, since it's off by default now.

• wtf/ThreadRestrictionVerifier.h:

(WTF::ThreadRestrictionVerifier::ThreadRestrictionVerifier): Turn off by default.

(WTF::ThreadRestrictionVerifier::setMutexMode):
(WTF::ThreadRestrictionVerifier::setDispatchQueueMode):
(WTF::ThreadRestrictionVerifier::turnOffVerification): These assertions
about state transitions were inconsistent with each other, and impossible
to maintain with default off, so I removed them.

File:

• trunk/Source/JavaScriptCore/parser/SourceProvider.h (modified) (1 diff)

trunk/Source/JavaScriptCore/parser/SourceProvider.h

@@ -50 +50 @@
             , m_cacheOwned(!cache)
         {
-            turnOffVerifier();
         }
+
         virtual ~SourceProvider()
         {