Changeset 128014 in webkit for trunk/Source/JavaScriptCore/API/JSContextRef.cpp

Timestamp:

Sep 9, 2012, 9:19:34 PM (13 years ago)

Author:

Patrick Gansterer

Message:

Add StringBuilder::appendNumber() and use it
​https://bugs.webkit.org/show_bug.cgi?id=96030

Reviewed by Eric Seidel.

Also fix a bunch of append() vs. appendLiteral() issues in the surrounding code.

Source/JavaScriptCore:

• API/JSContextRef.cpp:

(JSContextCreateBacktrace):

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
• interpreter/Interpreter.h:

(JSC::StackFrame::toString):

Source/WebCore:

• Modules/websockets/WebSocketHandshake.cpp:

(WebCore::hostName):

• bindings/v8/ScriptController.cpp:

(WebCore::resourceString):

• css/FontFeatureValue.cpp:

(WebCore::FontFeatureValue::customCssText):

• dom/Position.cpp:

(WebCore::Position::formatForDebugger):

• dom/Range.cpp:

(WebCore::Range::formatForDebugger):

• html/FormController.cpp:

(WebCore::FormKeyGenerator::formKey):

• html/HTMLAnchorElement.cpp:

(WebCore::appendServerMapMousePosition):

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::font):

• inspector/IdentifiersFactory.cpp:

(WebCore::IdentifiersFactory::addProcessIdPrefixTo):

• page/FrameTree.cpp:

(WebCore::FrameTree::uniqueChildName):

• page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::toRawString):

• platform/Decimal.cpp:

(WebCore::Decimal::toString):

• platform/network/ProxyServer.cpp:

(WebCore::appendProxyServerString):

• platform/text/TextStream.cpp:

(WebCore::TextStream::operator<<):

• platform/text/TextStream.h:
• rendering/RenderTreeAsText.cpp:

(WebCore::nodePosition):

• xml/XMLErrors.cpp:

(WebCore::XMLErrors::appendErrorMessage):

Source/WTF:

• wtf/DateMath.cpp:

(WTF::makeRFC2822DateString):

• wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::appendNumber):

• wtf/text/StringBuilder.h:

(StringBuilder):

File:

• trunk/Source/JavaScriptCore/API/JSContextRef.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/API/JSContextRef.cpp

@@ -201 +201 @@
         unsigned lineNumber = signedLineNumber >= 0 ? signedLineNumber : 0;
         if (!builder.isEmpty())
-            builder.append("\n");
-        builder.append("#");
+            builder.append('\n');
+        builder.append('#');
         builder.append(levelStr);
-        builder.append(" ");
+        builder.append(' ');
         builder.append(functionName);
-        builder.append("() at ");
+        builder.appendLiteral("() at ");
         builder.append(urlString);
-        builder.append(":");
-        builder.append(String::number(lineNumber));
+        builder.append(':');
+        builder.appendNumber(lineNumber);
         if (!function || ++count == maxStackSize)
             break;