Changeset 128015 in webkit for trunk/Source/JavaScriptCore/llint/LowLevelInterpreter.asm

Timestamp:

Sep 9, 2012, 9:25:23 PM (13 years ago)

Author:

[email protected]

Message:

Source/JavaScriptCore: Fixed a few llint C++ interpreter bugs.
​https://bugs.webkit.org/show_bug.cgi?id=96127.

Patch by Mark Lam <​[email protected]> on 2012-09-09
Reviewed by Geoffrey Garen.

• llint/LLIntCLoop.h:

CLoop::execute()'s bootstrapOpcodeId does not need a default
value. There is no case when this function is called without
that parameter being specified.

• llint/LowLevelInterpreter.asm:

Moved the dispatchAfterCall() call to where it is needed.
For the C_LOOP back-end, it generates unreachable code.

• llint/LowLevelInterpreter.cpp:

#include <wtf/Assertions.h> because LLIntAssembly.h needs it.

(JSC):

Fixed bug in SIGN_BIT32() macro.
Placate a MSVC warning for t0, and t1 being uninitialized.

(JSC::CLoop::execute):

The bootstrapOpcodeId arg should always be specified.
MSVC doesn't like UNUSED_PARAM() for labels. Switch to using

the new UNUSED_LABEL() macro.

• offlineasm/cloop.rb:
• offlineasm/generate_offset_extractor.rb:

Resolved a compiler warning found via MSVC.

Source/WTF: Fixed ASSERT() and ASSERT_AT() macros so that they can be used in
comma expressions. Also, added UNUSED_LABEL().
​https://bugs.webkit.org/show_bug.cgi?id=96127.

Patch by Mark Lam <​[email protected]> on 2012-09-09
Reviewed by Geoffrey Garen.

• wtf/Assertions.h:
• wtf/UnusedParam.h: Added UNUSED_LABEL(). Removed an obsolete comment.

File:

• trunk/Source/JavaScriptCore/llint/LowLevelInterpreter.asm (modified) (1 diff)

trunk/Source/JavaScriptCore/llint/LowLevelInterpreter.asm

@@ -178 +178 @@
             else
                 call callee
+                dispatchAfterCall()
             end
-            dispatchAfterCall()
         end)
 end