Changeset 128265 in webkit for trunk/Source/JavaScriptCore/runtime/Executable.h

Timestamp:

Sep 11, 2012, 11:14:56 PM (13 years ago)

Author:

[email protected]

Message:

Don't allocate a backing store just for a function's name
​https://bugs.webkit.org/show_bug.cgi?id=96468

Reviewed by Oliver Hunt.

Treat function.name like function.length etc., and use a custom getter.
This saves space in closures.

• debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::functionName):

• debugger/DebuggerCallFrame.h:

(DebuggerCallFrame): Updated for interface change.

• runtime/Executable.h:

(JSC::JSFunction::JSFunction): Do a little inlining.

• runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation): Gone now. That's the point of the patch.

(JSC::JSFunction::name):
(JSC::JSFunction::displayName):
(JSC::JSFunction::nameGetter):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnPropertyNames):
(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::defineOwnProperty): Added custom accessors for .name
just like .length and others.

• runtime/JSFunction.h:

(JSC::JSFunction::create):
(JSFunction): Updated for interface changes.

File:

• trunk/Source/JavaScriptCore/runtime/Executable.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/Executable.h

@@ -32 +32 @@
 #include "JSFunction.h"
 #include "Interpreter.h"
+#include "JSGlobalObject.h"
 #include "LLIntCLoop.h"
 #include "Nodes.h"
@@ -754 +755 @@
         WriteBarrier<SharedSymbolTable> m_symbolTable;
     };
+
+    inline JSFunction::JSFunction(JSGlobalData& globalData, FunctionExecutable* executable, JSScope* scope)
+        : Base(globalData, scope->globalObject()->functionStructure())
+        , m_executable(globalData, this, executable)
+        , m_scope(globalData, this, scope)
+    {
+    }
 
     inline FunctionExecutable* JSFunction::jsExecutable() const