Changeset 128704 in webkit for trunk/Source/JavaScriptCore/runtime/JSLock.h

Timestamp:

Sep 15, 2012, 11:08:18 PM (13 years ago)

Author:

[email protected]

Message:

Fixed JSLock to use the platform abstraction for Mutex instead of
depending on pthreads.
​https://bugs.webkit.org/show_bug.cgi?id=96858.

Reviewed by Filip Pizlo.

This fixes a synchronization problem on the Windows port and makes
it more reliable when running the layout tests.

• runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

• runtime/JSLock.cpp:

(JSC):
(JSC::GlobalJSLock::GlobalJSLock):
(JSC::GlobalJSLock::~GlobalJSLock):
(JSC::GlobalJSLock::initialize):

• runtime/JSLock.h:

(GlobalJSLock):
(JSLock):

File:

• trunk/Source/JavaScriptCore/runtime/JSLock.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/runtime/JSLock.h

@@ -59 +59 @@
         JS_EXPORT_PRIVATE GlobalJSLock();
         JS_EXPORT_PRIVATE ~GlobalJSLock();
+
+        static void initialize();
+    private:
+        static Mutex* s_sharedInstanceLock;
     };
 
@@ -92 +96 @@
         void grabAllLocks(unsigned lockCount);
 
-        SpinLock m_spinLock;
-        Mutex m_lock;
-        ThreadIdentifier m_ownerThread;
-        intptr_t m_lockCount;
-        unsigned m_lockDropDepth;
-
         class DropAllLocks {
             WTF_MAKE_NONCOPYABLE(DropAllLocks);
@@ -109 +107 @@
             RefPtr<JSGlobalData> m_globalData;
         };
+
+    private:
+        SpinLock m_spinLock;
+        Mutex m_lock;
+        ThreadIdentifier m_ownerThread;
+        intptr_t m_lockCount;
+        unsigned m_lockDropDepth;
     };