Changeset 12890 in webkit for trunk/JavaScriptCore/kjs/array_object.cpp

Timestamp:

Feb 18, 2006, 5:31:31 PM (19 years ago)

Author:

darin

Message:

JavaScriptCore:

Test: fast/js/toString-exception.html

Reviewed by Maciej.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7343 REGRESSION: fast/js/toString-overrides.html fails when run multiple times

• kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Remove the object from the visited elements set before returning an error.

LayoutTests:

Reviewed by Maciej.

• test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7343 REGRESSION: fast/js/toString-overrides.html fails when run multiple times

• fast/js/resources/toString-exception.js: Added.
• fast/js/toString-exception-expected.txt: Added.
• fast/js/toString-exception.html: Added.

File:

• trunk/JavaScriptCore/kjs/array_object.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/array_object.cpp

@@ -507 +507 @@
             str += static_cast<JSObject *>(conversionFunction)->call(exec, o, List())->toString(exec);
           } else {
+            visitedElems.remove(thisObj);
             return throwError(exec, RangeError, "Can't convert " + o->className() + " object to string");
           }