Changeset 129711 in webkit for trunk/Source/JavaScriptCore/jsc.cpp

Timestamp:

Sep 26, 2012, 3:50:27 PM (13 years ago)

Author:

[email protected]

Message:

Proxy the global this in JSC
​https://bugs.webkit.org/show_bug.cgi?id=97734

Reviewed by Oliver Hunt.

Having jsc diverge from WebCore here is not beneficial; it potentially masks bugs and/or performance
problems from command line testing.

• jsc.cpp:

(GlobalObject::create):

• Create a this value proxy for the global object.

• runtime/JSGlobalObject.h:

(JSGlobalObject):

• Make setGlobalThis protected.

• runtime/JSProxy.h:

(JSC::JSProxy::create):
(JSC::JSProxy::target):
(JSC::JSProxy::finishCreation):
(JSProxy):

• Allow proxy target to be a JSObject, add target to create method.

File:

• trunk/Source/JavaScriptCore/jsc.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/jsc.cpp

@@ -34 +34 @@
 #include "JSFunction.h"
 #include "JSLock.h"
+#include "JSProxy.h"
 #include "JSString.h"
 #include "SamplingTool.h"
@@ -177 +178 @@
         GlobalObject* object = new (NotNull, allocateCell<GlobalObject>(globalData.heap)) GlobalObject(globalData, structure);
         object->finishCreation(globalData, arguments);
+        object->setGlobalThis(globalData, JSProxy::create(globalData, JSProxy::createStructure(globalData, object), object));
         return object;
     }