Changeset 129773 in webkit for trunk/Source/JavaScriptCore/parser/Nodes.cpp

Timestamp:

Sep 27, 2012, 10:04:40 AM (13 years ago)

Author:

[email protected]

Message:

3.20MB below FunctionParameters::create() on Membuster3.
<​http://webkit.org/b/97730>

Reviewed by Anders Carlsson.

Figure out the exact space needed for parameter identifiers and use reserveInitialCapacity().
Reduces memory consumption on Membuster3 by ~1.60 MB.

• parser/Nodes.cpp:

(JSC::FunctionParameters::FunctionParameters):

File:

• trunk/Source/JavaScriptCore/parser/Nodes.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/parser/Nodes.cpp

@@ -154 +154 @@
 FunctionParameters::FunctionParameters(ParameterNode* firstParameter)
 {
+    unsigned parameterCount = 0;
     for (ParameterNode* parameter = firstParameter; parameter; parameter = parameter->nextParam())
-        append(parameter->ident());
+        ++parameterCount;
+
+    reserveInitialCapacity(parameterCount);
+
+    for (ParameterNode* parameter = firstParameter; parameter; parameter = parameter->nextParam())
+        uncheckedAppend(parameter->ident());
 }