Changeset 130344 in webkit for trunk/Source/JavaScriptCore/API/OpaqueJSString.cpp

Timestamp:

Oct 3, 2012, 4:40:28 PM (13 years ago)

Author:

[email protected]

Message:

OpaqueJSString doesn't optimally handle 8 bit strings
​https://bugs.webkit.org/show_bug.cgi?id=98300

Reviewed by Geoffrey Garen.

Change OpaqueJSString to store and manage a String instead of a UChar buffer.
The member string is a copy of any string used during creation.

• API/OpaqueJSString.cpp:

(OpaqueJSString::create):
(OpaqueJSString::identifier):

• API/OpaqueJSString.h:

(OpaqueJSString::characters):
(OpaqueJSString::length):
(OpaqueJSString::string):
(OpaqueJSString::OpaqueJSString):
(OpaqueJSString):

File:

• trunk/Source/JavaScriptCore/API/OpaqueJSString.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/API/OpaqueJSString.cpp

@@ -36 +36 @@
 {
     if (!string.isNull())
-        return adoptRef(new OpaqueJSString(string.characters(), string.length()));
-    return 0;
-}
-
-String OpaqueJSString::string() const
-{
-    if (this && m_characters)
-        return String(m_characters, m_length);
-    return String();
+        return adoptRef(new OpaqueJSString(string));
+    return adoptRef(new OpaqueJSString());
 }
 
 Identifier OpaqueJSString::identifier(JSGlobalData* globalData) const
 {
-    if (!this || !m_characters)
+    if (!this || !m_string.length())
         return Identifier(globalData, static_cast<const char*>(0));
 
-    return Identifier(globalData, m_characters, m_length);
+    return Identifier(globalData, m_string);
 }