Changeset 131111 in webkit for trunk/Source/WebCore/rendering/RenderFrameSet.cpp

Timestamp:

Oct 11, 2012, 4:47:28 PM (13 years ago)

Author:

[email protected]

Message:

[Sub pixel layout] Fast-path iframe scrolling can picks up an extra pixel
​https://bugs.webkit.org/show_bug.cgi?id=98571

Reviewed by Emil A Eklund.

Source/WebCore:

Refactoring all coordinate-switching functionality to use a single "mode" flag
as opposed to having a bunch of boolean values. This enables the same set of
options across the board, and a consistent interface. This was previously
done for mapLocalToContainer.

The imptetus for this for this stems from the one logical change in this patch
which only effects sub-pixel layout. FrameView::convertToRenderer and
convertFromRenderer return IntPoint coordinates, and need to also snap transform
offsets to determine proper rects for scrolling.

Unlabeled functions below are simply being updated to these new interfaces.

Test: fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html

• WebCore.exp.in:
• dom/ContainerNode.cpp:

(WebCore::ContainerNode::getUpperLeftCorner):
(WebCore::ContainerNode::getLowerRightCorner):

• dom/Element.cpp:

(WebCore::Element::boundsInRootViewSpace):

• dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::computeRelativePosition):

• dom/Node.cpp:

(WebCore::Node::convertToPage):
(WebCore::Node::convertFromPage):

• html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):

• html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::setPositionFromPoint):

• html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::defaultEventHandler):

• page/FrameView.cpp:

(WebCore::FrameView::convertToRenderer): Now pixel-snaps offsets before passing
them to TransformState, which transforms the coordinates.
(WebCore::FrameView::convertFromRenderer): Ditto.

• rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::absoluteQuads):

• rendering/RenderBox.cpp:

(WebCore::RenderBox::absoluteQuads):
(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::mapAbsoluteToLocalPoint):

• rendering/RenderBox.h:

(RenderBox):

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::mapAbsoluteToLocalPoint):

• rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

• rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::isInUnavailablePluginIndicator):

• rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::userResize):

• rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::absolutePoint):

• rendering/RenderInline.cpp:

(WebCore::RenderInline::mapLocalToContainer):

• rendering/RenderInline.h:

(RenderInline):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::absoluteToContents):
(WebCore::RenderLayer::calculateClipRects):

• rendering/RenderMediaControls.cpp:

(WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton):

• rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::showPopup):

• rendering/RenderObject.cpp:

(WebCore::RenderObject::localToAbsolute):
(WebCore::RenderObject::absoluteToLocal):
(WebCore::RenderObject::mapLocalToContainer):
(WebCore::RenderObject::mapAbsoluteToLocalPoint):
(WebCore::RenderObject::localToContainerQuad):
(WebCore::RenderObject::localToContainerPoint):

• rendering/RenderObject.h:

(RenderObject): MapLocalToContainerFlags is now MapCoordinatesFlags since it's
now used for other conversion methods.
(WebCore::RenderObject::localToAbsoluteQuad):

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):

• rendering/RenderView.cpp:

(WebCore::RenderView::mapLocalToContainer):
(WebCore::RenderView::mapAbsoluteToLocalPoint):

• rendering/RenderView.h:

(RenderView):

• rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::mapLocalToContainer):

• rendering/svg/RenderSVGForeignObject.h:

(RenderSVGForeignObject):

• rendering/svg/RenderSVGInline.cpp:

(WebCore::RenderSVGInline::mapLocalToContainer):

• rendering/svg/RenderSVGInline.h:

(RenderSVGInline):

• rendering/svg/RenderSVGModelObject.cpp:

(WebCore::RenderSVGModelObject::mapLocalToContainer):

• rendering/svg/RenderSVGModelObject.h:

(RenderSVGModelObject):

• rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::mapLocalToContainer):

• rendering/svg/RenderSVGRoot.h:

(RenderSVGRoot):

• rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::mapLocalToContainer):

• rendering/svg/RenderSVGText.h:

(RenderSVGText):

• rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::mapLocalToContainer):

• svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::localCoordinateSpaceTransform):

LayoutTests:

Tests scrolling of sub-pixel layers on sub-pixel platforms (Chromium).

• fast/sub-pixel/sub-pixel-iframe-copy-on-scroll.html: Added.
• platform/chromium-linux/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.png: Added.
• platform/chromium-linux/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt: Added.
• platform/chromium-linux/fast/repaint/repaint-across-writing-mode-boundary-expected.png:

The repaint rect shrinks safely by one pixel.

• platform/chromium/TestExpectations:
• platform/mac-lion/TestExpectations:
• platform/mac-snowleopard/TestExpectations:
• platform/mac-wk2/TestExpectations:
• platform/mac/TestExpectations:
• platform/qt-4.8/TestExpectations:
• platform/qt/TestExpectations:
• platform/win-wk2/TestExpectations:
• platform/win-xp/TestExpectations:
• platform/win/TestExpectations:
• platform/wincairo/TestExpectations:
• platform/wk2/TestExpectations:

File:

• trunk/Source/WebCore/rendering/RenderFrameSet.cpp (modified) (2 diffs)

trunk/Source/WebCore/rendering/RenderFrameSet.cpp

@@ -700 +700 @@
             return false;
         if (evt->type() == eventNames().mousedownEvent && evt->button() == LeftButton) {
-            FloatPoint localPos = absoluteToLocal(evt->absoluteLocation(), false, true);
+            FloatPoint localPos = absoluteToLocal(evt->absoluteLocation(), UseTransforms | SnapOffsetForTransforms);
             startResizing(m_cols, localPos.x());
             startResizing(m_rows, localPos.y());
@@ -710 +710 @@
     } else {
         if (evt->type() == eventNames().mousemoveEvent || (evt->type() == eventNames().mouseupEvent && evt->button() == LeftButton)) {
-            FloatPoint localPos = absoluteToLocal(evt->absoluteLocation(), false, true);
+            FloatPoint localPos = absoluteToLocal(evt->absoluteLocation(), UseTransforms | SnapOffsetForTransforms);
             continueResizing(m_cols, localPos.x());
             continueResizing(m_rows, localPos.y());