Changeset 131956 in webkit for trunk/Source/JavaScriptCore/parser/Lexer.cpp

Timestamp:

Oct 19, 2012, 4:23:34 PM (13 years ago)

Author:

[email protected]

Message:

Lexer should create 8 bit Identifiers for RegularExpressions and ASCII identifiers
​https://bugs.webkit.org/show_bug.cgi?id=99855

Reviewed by Filip Pizlo.

Added makeIdentifier helpers that will always make an 8 bit Identifier or make an
Identifier that is the same size as the template parameter. Used the first in the fast
path when looking for a JS identifier and the second when scanning regular expressions.

• parser/Lexer.cpp:

(JSC::::scanRegExp):

• parser/Lexer.h:

(Lexer):
(JSC::::makeIdentifierSameType):
(JSC::::makeLCharIdentifier):
(JSC::::lexExpectIdentifier):

File:

• trunk/Source/JavaScriptCore/parser/Lexer.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/parser/Lexer.cpp

@@ -1618 +1618 @@
     }
 
-    pattern = makeIdentifier(m_buffer16.data(), m_buffer16.size());
+    pattern = makeIdentifierSameType(m_buffer16.data(), m_buffer16.size());
     m_buffer16.resize(0);
 
@@ -1626 +1626 @@
     }
 
-    flags = makeIdentifier(m_buffer16.data(), m_buffer16.size());
+    flags = makeIdentifierSameType(m_buffer16.data(), m_buffer16.size());
     m_buffer16.resize(0);