Changeset 13203 in webkit for trunk/JavaScriptCore/kjs/lexer.cpp

Timestamp:

Mar 8, 2006, 12:30:57 AM (19 years ago)

Author:

darin

Message:

JavaScriptCore:

Reviewed by Anders.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7655 unwanted output while running layout tests

• kjs/lexer.cpp: (Lexer::lex): Turn off the "yylex: ERROR" message.
• kjs/regexp.cpp: (KJS::RegExp::RegExp): Remove the code to log errors from PCRE to standard output. I think we should arrange for the error text to be in JavaScript exceptions instead at some point.
• kxmlcore/Vector.h: Add a check for overflow so that we'll abort if we pass a too-large size rather than allocating a buffer smaller than requested.

WebCore:

Reviewed by Anders.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7655 unwanted output while running layout tests

• khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::parseString): Pass XML_PARSE_NOERROR and XML_PARSE_NOWARNING. We don't want errors and warnings to be logged to stdout or stderr. If we later decide we want the error messages, then we should do the additional work to put them into the web page or the console (along with the JavaScript errors).

• platform/ArrayImpl.cpp: (WebCore::ArrayImpl::resize): Add a preflight to protect against integer overflow due to large array size. Noticed this while looking into the malloc error message.

WebKit:

Reviewed by Anders.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7655 unwanted output while running layout tests

• WebView/WebDataSourcePrivate.h:
• WebView/WebDataSource.m: (-[WebDataSource _setRepresentation:]): Clear the flag that records whether we've sent all the data to the representation or not; need this to prevent telling the same representation both that we've succeeded and then later that we've failed. (-[WebDataSource _setMainDocumentError:]): Don't send an error if representationFinishedLoading is already YES. Set representationFinishedLoading. (-[WebDataSource _finishedLoading]): Set representationFinishedLoading. (-[WebDataSource _setupForReplaceByMIMEType:]): Ditto.

WebKitTools:

Reviewed by Anders.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7655 unwanted output while running layout tests

• DumpRenderTree/DumpRenderTree.m: (checkedMalloc): Added. (checkedRealloc): Added. (makeLargeMallocFailSilently): Added. (main): Call makeLargeMallocFailSilently.

File:

• trunk/JavaScriptCore/kjs/lexer.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/lexer.cpp

@@ -557 +557 @@
     break;
   case Bad:
+#ifdef KJS_DEBUG_LEX
     fprintf(stderr, "yylex: ERROR.\n");
+#endif
     error = true;
     return -1;