Changeset 13294 in webkit for trunk/JavaScriptCore/kjs/ustring.cpp

Timestamp:

Mar 14, 2006, 5:09:15 PM (19 years ago)

Author:

ggaren

Message:

JavaScriptCore:

• Fixed <rdar://problem/4478239> string sort puts "closed" before "close"

Reviewed by Eric.

• kjs/ustring.cpp: (KJS::compare): Inverted a < in order to treat the longer string as > the shorter string.

LayoutTests:

Reviewed by Eric.

Layout test for <rdar://problem/4478239> string sort puts "closed"
before "close"

Also changed the engine to report data types when tests fail, so that
you don't get messages like, "should be A, was A."

Updated results for these files:

• fast/js/kde/Array-expected.txt:
• fast/js/kde/RegExp-expected.txt:
• fast/js/kde/encode_decode_uri-expected.txt:
• fast/js/resources/js-test-pre.js:

Added these files:

• fast/js/string-sort-expected.txt: Added.
• fast/js/string-sort.html: Added.

File:

• trunk/JavaScriptCore/kjs/ustring.cpp (modified) (1 diff)

trunk/JavaScriptCore/kjs/ustring.cpp

@@ -1177 +1177 @@
     l++;
   }
+
   if (l < lmin)
     return (c1->uc > c2->uc) ? 1 : -1;
 
-  if (l1 == l2) {
+  if (l1 == l2)
     return 0;
-  }
-  return (l1 < l2) ? 1 : -1;
+
+  return (l1 > l2) ? 1 : -1;
 }