Changeset 133975 in webkit for trunk/Source/JavaScriptCore/runtime/Executable.cpp

Timestamp:

Nov 8, 2012, 5:12:47 PM (13 years ago)

Author:

[email protected]

Message:

Improve effectiveness of function-level caching
​https://bugs.webkit.org/show_bug.cgi?id=101667

Reviewed by Filip Pizlo.

Added a random-eviction based cache for unlinked functions, and switch
UnlinkedFunctionExecutable's code references to Weak<>, thereby letting
us remove the explicit UnlinkedFunctionExecutable::clearCode() calls that
were being triggered by GC.

Refactored the random eviction part of the CodeCache into a separate data
structure so that I didn't have to duplicate the code again, and then used
that for the new function cache.

• bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::visitChildren):
(JSC::UnlinkedFunctionExecutable::codeBlockFor):

• bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedFunctionExecutable::clearCodeForRecompilation):
(UnlinkedFunctionExecutable):

• debugger/Debugger.cpp:
• runtime/CodeCache.cpp:

(JSC::CodeCache::getCodeBlock):
(JSC::CodeCache::generateFunctionCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
(JSC::CodeCache::usedFunctionCode):
(JSC):

• runtime/Executable.cpp:

(JSC::FunctionExecutable::clearUnlinkedCodeForRecompilationIfNotCompiling):
(JSC::FunctionExecutable::clearCode):

• runtime/Executable.h:

(FunctionExecutable):

File:

• trunk/Source/JavaScriptCore/runtime/Executable.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/Executable.cpp

@@ -621 +621 @@
 }
 
-void FunctionExecutable::clearUnlinkedCodeIfNotCompiling()
+void FunctionExecutable::clearUnlinkedCodeForRecompilationIfNotCompiling()
 {
     if (isCompiling())
         return;
-    m_unlinkedExecutable->clearCode();
+    m_unlinkedExecutable->clearCodeForRecompilation();
 }
 
@@ -632 +632 @@
     m_codeBlockForCall.clear();
     m_codeBlockForConstruct.clear();
-    m_unlinkedExecutable->clearCode();
     Base::clearCode();
 }