Changeset 134460 in webkit for trunk/Source/JavaScriptCore/runtime/JSFunction.cpp

Timestamp:

Nov 13, 2012, 11:58:18 AM (13 years ago)

Author:

[email protected]

Message:

JSFunction and its descendants should be destructible
​https://bugs.webkit.org/show_bug.cgi?id=102062

Reviewed by Mark Hahnenberg.

This will make it easy to place an InlineWatchpointSet inside JSFunction. In the
future, we could make JSFunction non-destructible again by making a version of
WatchpointSet that is entirely GC'd, but this seems like overkill for now.

This is performance-neutral.

• runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::destroy):
(JSC):

• runtime/JSBoundFunction.h:

(JSBoundFunction):

• runtime/JSFunction.cpp:

(JSC):
(JSC::JSFunction::destroy):

• runtime/JSFunction.h:

(JSFunction):

File:

• trunk/Source/JavaScriptCore/runtime/JSFunction.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/runtime/JSFunction.cpp

@@ -49 +49 @@
 }
 
-ASSERT_HAS_TRIVIAL_DESTRUCTOR(JSFunction);
-
 const ClassInfo JSFunction::s_info = { "Function", &Base::s_info, 0, 0, CREATE_METHOD_TABLE(JSFunction) };
 
@@ -75 +73 @@
     function->finishCreation(exec, executable, length, name);
     return function;
+}
+
+void JSFunction::destroy(JSCell* cell)
+{
+    static_cast<JSFunction*>(cell)->JSFunction::~JSFunction();
 }