Changeset 134460 in webkit for trunk/Source/JavaScriptCore/runtime/JSFunction.h

Timestamp:

Nov 13, 2012, 11:58:18 AM (13 years ago)

Author:

[email protected]

Message:

JSFunction and its descendants should be destructible
​https://bugs.webkit.org/show_bug.cgi?id=102062

Reviewed by Mark Hahnenberg.

This will make it easy to place an InlineWatchpointSet inside JSFunction. In the
future, we could make JSFunction non-destructible again by making a version of
WatchpointSet that is entirely GC'd, but this seems like overkill for now.

This is performance-neutral.

• runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::destroy):
(JSC):

• runtime/JSBoundFunction.h:

(JSBoundFunction):

• runtime/JSFunction.cpp:

(JSC):
(JSC::JSFunction::destroy):

• runtime/JSFunction.h:

(JSFunction):

File:

• trunk/Source/JavaScriptCore/runtime/JSFunction.h (modified) (4 diffs)

trunk/Source/JavaScriptCore/runtime/JSFunction.h

@@ -26 +26 @@
 
 #include "InternalFunction.h"
+#include "JSDestructibleObject.h"
 #include "JSScope.h"
 
@@ -47 +48 @@
     JS_EXPORT_PRIVATE String getCalculatedDisplayName(CallFrame*, JSObject*);
     
-    class JSFunction : public JSNonFinalObject {
+    class JSFunction : public JSDestructibleObject {
         friend class JIT;
         friend class DFG::SpeculativeJIT;
@@ -54 +55 @@
 
     public:
-        typedef JSNonFinalObject Base;
+        typedef JSDestructibleObject Base;
 
         JS_EXPORT_PRIVATE static JSFunction* create(ExecState*, JSGlobalObject*, int length, const String& name, NativeFunction, Intrinsic = NoIntrinsic, NativeFunction nativeConstructor = callHostFunctionAsConstructor);
@@ -66 +67 @@
             return function;
         }
+        
+        static void destroy(JSCell*);
         
         JS_EXPORT_PRIVATE String name(ExecState*);