Changeset 13541 in webkit for trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

Timestamp:

Mar 28, 2006, 4:09:20 PM (19 years ago)

Author:

darin

Message:

Reviewed by Geoff.

• change some code that resulted in init routines on Mac OS X -- if the framework has init routines it will use memory and slow down applications that link with WebKit even in cases where those applications don't use WebKit

• kjs/date_object.cpp: Changed constants that were derived by multiplying other constants to use immediate numbers instead. Apparently, double constant expressions of the type we had here are evaluated at load time.

• kjs/list.cpp: Can't use OwnArrayPtr in ListImp because of the global instances of ListImp, so go back to using a plain old pointer. (KJS::List::List): Set overflow to 0 when initializing ListImp. (KJS::List::release): Replace a clear call with a delete and explicit set to 0. (KJS::List::append): Use raw pointers, and do a delete [] instead of finessing it with a swap of OwnArrayPtr. (KJS::List::copyFrom): Remove now-unneeded get(). (KJS::List::copyTail): Ditto.

• kjs/ustring.cpp: Changed UString::Rep::empty initializer a bit so that it doesn't get a static initializer routine. Had to get rid of one level of constant to get the compiler to understand it could initialize without any code.

• added a build step that checks for init routines

• JavaScriptCore.xcodeproj/project.pbxproj: Deleted now-unused custom build rule that was replaced by the generate-derived-sources script a while back. Added a custom build phase that invokes the check-for-global-initializers script.

File:

• trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj (modified) (3 diffs)

trunk/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

@@ -232 +232 @@
                 93F0B3AC09BB4DC00068FCE3 /* Parser.h in Headers */ = {isa = PBXBuildFile; fileRef = 93F0B3AA09BB4DC00068FCE3 /* Parser.h */; };
 /* End PBXBuildFile section */
-
-/* Begin PBXBuildRule section */
-                937C34BA0868E21B006F4B22 /* PBXBuildRule */ = {
-                        isa = PBXBuildRule;
-                        compilerSpec = com.apple.compilers.proxy.script;
-                        fileType = sourcecode.yacc;
-                        isEditable = 1;
-                        outputFiles = (
-                                "$(DERIVED_FILE_DIR)/$(INPUT_FILE_BASE).h",
-                                "$(DERIVED_FILE_DIR)/$(INPUT_FILE_BASE).cpp",
-                        );
-                        script = "bison -d -p kjsyy \"$INPUT_FILE_PATH\" -o \"$DERIVED_FILE_DIR/$INPUT_FILE_BASE.cpp\"\ncat \"$DERIVED_FILE_DIR/$INPUT_FILE_BASE.cpp.h\" \"$DERIVED_FILE_DIR/$INPUT_FILE_BASE.hpp\" > \"$DERIVED_FILE_DIR/$INPUT_FILE_BASE.h\" 2> /dev/null || printf \"\"";
-                };
-/* End PBXBuildRule section */
 
 /* Begin PBXBuildStyle section */
@@ -952 +938 @@
                                 932F5B3F0822A1C700736975 /* Headers */,
                                 932F5B910822A1C700736975 /* Sources */,
+                                9319586B09D9F91A00A56FD4 /* Check For Global Initializers */,
                                 932F5BD20822A1C700736975 /* Frameworks */,
                         );
                         buildRules = (
-                                937C34BA0868E21B006F4B22 /* PBXBuildRule */,
                         );
                         buildSettings = {
@@ -1109 +1095 @@
                         shellPath = /bin/sh;
                         shellScript = "./generate-derived-sources\n";
+                };
+                9319586B09D9F91A00A56FD4 /* Check For Global Initializers */ = {
+                        isa = PBXShellScriptBuildPhase;
+                        buildActionMask = 2147483647;
+                        files = (
+                        );
+                        inputPaths = (
+                        );
+                        name = "Check For Global Initializers";
+                        outputPaths = (
+                        );
+                        runOnlyForDeploymentPostprocessing = 0;
+                        shellPath = /bin/sh;
+                        shellScript = "if [ -f ../WebKitTools/Scripts/check-for-global-initializers ]; then\n    ../WebKitTools/Scripts/check-for-global-initializers || exit $?\nfi";
                 };
 /* End PBXShellScriptBuildPhase section */