Changeset 135466 in webkit for trunk/Source/JavaScriptCore/dfg/DFGDisassembler.cpp

Timestamp:

Nov 21, 2012, 7:47:23 PM (13 years ago)

Author:

[email protected]

Message:

It should be possible to say disassemble(stuff) instead of having to say if (!tryToDisassemble(stuff)) dataLog("I failed")
​https://bugs.webkit.org/show_bug.cgi?id=103010

Reviewed by Anders Carlsson.

You can still say tryToDisassemble(), which will tell you if it failed; you can then
decide what to do instead. But it's better to say disassemble(), which will just print
the instruction ranges if tryToDisassemble() failed. This is particularly appropriate
since that's what all previous users of tryToDisassemble() would have done in some
form or another.

• CMakeLists.txt:
• GNUmakefile.list.am:
• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Target.pri:
• assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::finalizeCodeWithDisassembly):

• dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::dumpDisassembly):

• disassembler/Disassembler.cpp: Added.

(JSC):
(JSC::disassemble):

• disassembler/Disassembler.h:

(JSC):

• jit/JITDisassembler.cpp:

(JSC::JITDisassembler::dumpDisassembly):

File:

• trunk/Source/JavaScriptCore/dfg/DFGDisassembler.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGDisassembler.cpp

@@ -105 +105 @@
     previousLabel = currentLabel;
     ASSERT(bitwise_cast<uintptr_t>(end.executableAddress()) >= bitwise_cast<uintptr_t>(start.executableAddress()));
-    if (tryToDisassemble(start, bitwise_cast<uintptr_t>(end.executableAddress()) - bitwise_cast<uintptr_t>(start.executableAddress()), prefixBuffer.get(), WTF::dataFile()))
-        return;
-    
-    dataLog("%s    disassembly not available for range %p...%p\n", prefixBuffer.get(), start.executableAddress(), end.executableAddress());
+    disassemble(start, bitwise_cast<uintptr_t>(end.executableAddress()) - bitwise_cast<uintptr_t>(start.executableAddress()), prefixBuffer.get(), WTF::dataFile());
 }