Changeset 136049 in webkit for trunk/Source/JavaScriptCore/parser/SourceProviderCacheItem.h

Timestamp:

Nov 28, 2012, 1:11:53 PM (13 years ago)

Author:

[email protected]

Message:

Make source cache include more information about the function extent.
​https://bugs.webkit.org/show_bug.cgi?id=103552

Reviewed by Gavin Barraclough.

Add a bit more information to the source cache.

• parser/Parser.cpp:

(JSC::::parseFunctionInfo):

Store the function start offset

• parser/SourceProviderCacheItem.h:

(JSC::SourceProviderCacheItem::SourceProviderCacheItem):
(SourceProviderCacheItem):

Add additional field for the start of the real function string, and re-arrange
fields to avoid growing the struct.

File:

• trunk/Source/JavaScriptCore/parser/SourceProviderCacheItem.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/parser/SourceProviderCacheItem.h

@@ -36 +36 @@
     WTF_MAKE_FAST_ALLOCATED;
 public:
-    SourceProviderCacheItem(int closeBraceLine, int closeBracePos)
-        : closeBraceLine(closeBraceLine) 
+    SourceProviderCacheItem(unsigned functionStart, unsigned closeBraceLine, unsigned closeBracePos)
+        : functionStart(functionStart)
+        , closeBraceLine(closeBraceLine)
         , closeBracePos(closeBracePos)
     {
@@ -60 +61 @@
         return token;
     }
+
+    unsigned functionStart : 31;
+    bool needsFullActivation : 1;
     
-    int closeBraceLine;
-    int closeBracePos;
-    bool usesEval;
-    bool strictMode;
-    bool needsFullActivation;
+    unsigned closeBraceLine : 31;
+    bool usesEval : 1;
+
+    unsigned closeBracePos : 31;
+    bool strictMode : 1;
+
     Vector<RefPtr<StringImpl> > usedVariables;
     Vector<RefPtr<StringImpl> > writtenVariables;