Changeset 136261 in webkit for trunk/Source/JavaScriptCore/parser/ASTBuilder.h

Timestamp:

Nov 30, 2012, 1:09:21 PM (13 years ago)

Author:

[email protected]

Message:

Add direct string->function code cache
​https://bugs.webkit.org/show_bug.cgi?id=103764

Reviewed by Michael Saboff.

A fairly logically simple patch. We now track the start of the
unique portion of a functions body, and use that as our key for
unlinked function code. This allows us to cache identical code
in different contexts, leading to a small but consistent improvement
on the benchmarks we track.

• bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):

• bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedFunctionExecutable::functionStartOffset):
(UnlinkedFunctionExecutable):

• parser/ASTBuilder.h:

(ASTBuilder):
(JSC::ASTBuilder::setFunctionStart):

• parser/Nodes.cpp:
• parser/Nodes.h:

(JSC::FunctionBodyNode::setFunctionStart):
(JSC::FunctionBodyNode::functionStart):
(FunctionBodyNode):

• parser/Parser.cpp:

(JSC::::parseFunctionInfo):

• parser/Parser.h:

(JSC::Parser::findCachedFunctionInfo):

• parser/SyntaxChecker.h:

(JSC::SyntaxChecker::setFunctionStart):

• runtime/CodeCache.cpp:

(JSC::CodeCache::generateFunctionCodeBlock):
(JSC::CodeCache::getFunctionCodeBlock):
(JSC::CodeCache::usedFunctionCode):

• runtime/CodeCache.h:

File:

• trunk/Source/JavaScriptCore/parser/ASTBuilder.h (modified) (1 diff)

trunk/Source/JavaScriptCore/parser/ASTBuilder.h

@@ -268 +268 @@
         return FunctionBodyNode::create(m_globalData, location, inStrictContext);
     }
+
+    void setFunctionStart(FunctionBodyNode* body, int functionStart)
+    {
+        body->setFunctionStart(functionStart);
+    }
     
     template <bool> PropertyNode* createGetterOrSetterProperty(const JSTokenLocation& location, PropertyNode::Type type, const Identifier* name, ParameterNode* params, FunctionBodyNode* body, int openBracePos, int closeBracePos, int bodyStartLine, int bodyEndLine)