Changeset 136261 in webkit for trunk/Source/JavaScriptCore/parser/Nodes.h

Timestamp:

Nov 30, 2012, 1:09:21 PM (13 years ago)

Author:

[email protected]

Message:

Add direct string->function code cache
​https://bugs.webkit.org/show_bug.cgi?id=103764

Reviewed by Michael Saboff.

A fairly logically simple patch. We now track the start of the
unique portion of a functions body, and use that as our key for
unlinked function code. This allows us to cache identical code
in different contexts, leading to a small but consistent improvement
on the benchmarks we track.

• bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):

• bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedFunctionExecutable::functionStartOffset):
(UnlinkedFunctionExecutable):

• parser/ASTBuilder.h:

(ASTBuilder):
(JSC::ASTBuilder::setFunctionStart):

• parser/Nodes.cpp:
• parser/Nodes.h:

(JSC::FunctionBodyNode::setFunctionStart):
(JSC::FunctionBodyNode::functionStart):
(FunctionBodyNode):

• parser/Parser.cpp:

(JSC::::parseFunctionInfo):

• parser/Parser.h:

(JSC::Parser::findCachedFunctionInfo):

• parser/SyntaxChecker.h:

(JSC::SyntaxChecker::setFunctionStart):

• runtime/CodeCache.cpp:

(JSC::CodeCache::generateFunctionCodeBlock):
(JSC::CodeCache::getFunctionCodeBlock):
(JSC::CodeCache::usedFunctionCode):

• runtime/CodeCache.h:

File:

• trunk/Source/JavaScriptCore/parser/Nodes.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/parser/Nodes.h

@@ -47 +47 @@
     class JSScope;
     class ScopeNode;
+    class SourceProviderCacheItem;
 
     typedef unsigned CodeFeatures;
@@ -1425 +1426 @@
         FunctionNameIsInScopeToggle functionNameIsInScopeToggle() { return m_functionNameIsInScopeToggle; }
 
+        void setFunctionStart(int functionStart) { m_functionStart = functionStart; }
+        int functionStart() const { return m_functionStart; }
+
         static const bool scopeIsFunction = true;
 
@@ -1435 +1439 @@
         FunctionNameIsInScopeToggle m_functionNameIsInScopeToggle;
         RefPtr<FunctionParameters> m_parameters;
+        int m_functionStart;
     };