Changeset 13709 in webkit for trunk/JavaScriptCore/kxmlcore/HashTable.h

Timestamp:

Apr 5, 2006, 5:13:50 PM (19 years ago)

Author:

darin

Message:

Reviewed by Maciej.

• fix memory leak introduced by the previous change

• kxmlcore/HashTable.h: Specialize NeedsRef so that it correctly returns true when the value in question is a pair where one of the pair needs a ref and the other of the pair does not.

File:

• trunk/JavaScriptCore/kxmlcore/HashTable.h (modified) (1 diff)

trunk/JavaScriptCore/kxmlcore/HashTable.h

@@ -836 +836 @@
         static const bool value = ValueTraits::needsRef && !ValueStorageTraits::needsRef;
     };
+    template<typename FirstTraits, typename SecondTraits, typename ValueStorageTraits>
+    struct NeedsRef<PairBaseHashTraits<FirstTraits, SecondTraits>, ValueStorageTraits> {
+        typedef typename ValueStorageTraits::FirstTraits FirstStorageTraits;
+        typedef typename ValueStorageTraits::SecondTraits SecondStorageTraits;
+        static const bool firstNeedsRef = NeedsRef<FirstTraits, FirstStorageTraits>::value;
+        static const bool secondNeedsRef = NeedsRef<SecondTraits, SecondStorageTraits>::value;
+        static const bool value = firstNeedsRef || secondNeedsRef;
+    };
 
     template<bool needsRef, typename ValueTraits> struct RefCounterBase;