Changeset 13752 in webkit for trunk/JavaScriptCore/kjs/nodes.cpp

Timestamp:

Apr 9, 2006, 10:06:35 PM (19 years ago)

Author:

ggaren

Message:

Reviewed by eric.

• Fixed ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8284 prevent unnecessary entries in the "nodes with extra refs" hash table

This patch switches manual RefPtr exchange with use of
RefPtr::release to ensure that a node's ref count never tops 1
(in the normal case).

• kjs/nodes.cpp: (BlockNode::BlockNode): (CaseBlockNode::CaseBlockNode):
• kjs/nodes.h: (KJS::ArrayNode::ArrayNode): (KJS::ObjectLiteralNode::ObjectLiteralNode): (KJS::ArgumentsNode::ArgumentsNode): (KJS::VarStatementNode::VarStatementNode): (KJS::ForNode::ForNode): (KJS::CaseClauseNode::CaseClauseNode): (KJS::FuncExprNode::FuncExprNode): (KJS::FuncDeclNode::FuncDeclNode):

File:

• trunk/JavaScriptCore/kjs/nodes.cpp (modified) (3 diffs)

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -1678 +1678 @@
 {
   if (s) {
-    source = s->next;
+    source = s->next.release();
     Parser::removeNodeCycle(source.get());
-    s->next = 0;
     setLoc(s->firstLine(), s->lastLine());
   } else {
@@ -2144 +2143 @@
 {
   if (l1) {
-    list1 = l1->next;
+    list1 = l1->next.release();
     Parser::removeNodeCycle(list1.get());
-    l1->next = 0;
   } else {
     list1 = 0;
@@ -2154 +2152 @@
 
   if (l2) {
-    list2 = l2->next;
+    list2 = l2->next.release();
     Parser::removeNodeCycle(list2.get());
-    l2->next = 0;
   } else {
     list2 = 0;