Changeset 139145 in webkit for trunk/Source/JavaScriptCore/runtime/JSString.h

Timestamp:

Jan 8, 2013, 6:37:29 PM (13 years ago)

Author:

[email protected]

Message:

Support op_typeof in the DFG
​https://bugs.webkit.org/show_bug.cgi?id=98898

Reviewed by Filip Pizlo.

Adds a TypeOf node to the DFG to support op_typeof.

To avoid adding too much GC horror, this also makes the
common strings portion of the SmallString cache strongly
referenced.

• dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

We try to determine the result early here, and substitute in a constant.
Otherwise we leave the node intact, and set the result type to SpecString.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

Parse op_typeof

• dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

TypeOf nodes can be subjected to pure CSE

• dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

We can handle typeof.

• dfg/DFGNodeType.h:

(DFG):

Define the node.

• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h: Add operationTypeOf to support the non-trivial cases.
• dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

Actual codegen

• runtime/Operations.cpp:

(JSC::jsTypeStringForValue):
(JSC):

• runtime/Operations.h:

(JSC):

Some refactoring to allow us to get the type string for an
object without needing a callframe.

File:

• trunk/Source/JavaScriptCore/runtime/JSString.h (modified) (6 diffs)

trunk/Source/JavaScriptCore/runtime/JSString.h

@@ -334 +334 @@
     inline JSString* jsEmptyString(JSGlobalData* globalData)
     {
-        return globalData->smallStrings.emptyString(globalData);
+        return globalData->smallStrings.emptyString();
     }
 
@@ -387 +387 @@
         int size = s.length();
         if (!size)
-            return globalData->smallStrings.emptyString(globalData);
+            return globalData->smallStrings.emptyString();
         if (size == 1) {
             UChar c = s.characterAt(0);
@@ -403 +403 @@
         JSGlobalData* globalData = &exec->globalData();
         if (!length)
-            return globalData->smallStrings.emptyString(globalData);
+            return globalData->smallStrings.emptyString();
         return jsSubstring(globalData, s->value(exec), offset, length);
     }
@@ -413 +413 @@
         ASSERT(offset + length <= static_cast<unsigned>(s.length()));
         if (!length)
-            return globalData->smallStrings.emptyString(globalData);
+            return globalData->smallStrings.emptyString();
         if (length == 1) {
             UChar c = s.characterAt(offset);
@@ -428 +428 @@
         ASSERT(offset + length <= static_cast<unsigned>(s.length()));
         if (!length)
-            return globalData->smallStrings.emptyString(globalData);
+            return globalData->smallStrings.emptyString();
         if (length == 1) {
             UChar c = s.characterAt(offset);
@@ -441 +441 @@
         int size = s.length();
         if (!size)
-            return globalData->smallStrings.emptyString(globalData);
+            return globalData->smallStrings.emptyString();
         if (size == 1) {
             UChar c = s.characterAt(0);