Changeset 141222 in webkit for trunk/Source/JavaScriptCore/parser/Nodes.h

Timestamp:

Jan 29, 2013, 9:43:47 PM (12 years ago)

Author:

[email protected]

Message:

Be a little more conservative about emitting table-based switches
​https://bugs.webkit.org/show_bug.cgi?id=108292

Reviewed by Filip Pizlo.

Profiling shows we're using op_switch in cases where it's a regression.

• bytecompiler/NodesCodegen.cpp:

(JSC):
(JSC::length):
(JSC::CaseBlockNode::tryTableSwitch):
(JSC::CaseBlockNode::emitBytecodeForBlock):

• parser/Nodes.h:

(CaseBlockNode):

File:

• trunk/Source/JavaScriptCore/parser/Nodes.h (modified) (1 diff)

trunk/Source/JavaScriptCore/parser/Nodes.h

@@ -1510 +1510 @@
 
     private:
-        SwitchInfo::SwitchType tryOptimizedSwitch(Vector<ExpressionNode*, 8>& literalVector, int32_t& min_num, int32_t& max_num);
+        SwitchInfo::SwitchType tryTableSwitch(Vector<ExpressionNode*, 8>& literalVector, int32_t& min_num, int32_t& max_num);
+        static const size_t s_tableSwitchMinimum = 10;
         ClauseListNode* m_list1;
         CaseClauseNode* m_defaultClause;