Changeset 143384 in webkit for trunk/Source/JavaScriptCore/parser/SourceCode.h

Timestamp:

Feb 19, 2013, 2:29:03 PM (12 years ago)

Author:

[email protected]

Message:

Unreviewed, rolling in r143348.
​http://trac.webkit.org/changeset/143348
​https://bugs.webkit.org/show_bug.cgi?id=110242

The bug was that isEmptyValue() was returning true for the deleted value.
Fixed this and simplified things further by delegating to m_sourceCode
for both isNull() and isHashTableDeletedValue(), so they can't be out of
sync.

• runtime/CodeCache.cpp:

(JSC::CodeCache::getFunctionExecutableFromGlobalCode):

• runtime/CodeCache.h:

(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::length):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(SourceCodeKey):

File:

• trunk/Source/JavaScriptCore/parser/SourceCode.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/parser/SourceCode.h

@@ -45 +45 @@
         }
 
+        SourceCode(WTF::HashTableDeletedValueType)
+            : m_provider(WTF::HashTableDeletedValue)
+        {
+        }
+
         SourceCode(PassRefPtr<SourceProvider> provider, int firstLine = 1)
             : m_provider(provider)
@@ -60 +65 @@
         {
         }
+
+        bool isHashTableDeletedValue() const { return m_provider.isHashTableDeletedValue(); }
 
         String toString() const