Changeset 144026 in webkit for trunk/Source/JavaScriptCore/profiler/LegacyProfiler.cpp

Timestamp:

Feb 26, 2013, 1:47:57 AM (12 years ago)

Author:

[email protected]

Message:

Kill another analyzer warning in javascriptcore
​https://bugs.webkit.org/show_bug.cgi?id=110802

Reviewed by Benjamin Poulain.

Add null checks.

• profiler/LegacyProfiler.cpp:

(JSC::LegacyProfiler::startProfiling):
(JSC::LegacyProfiler::stopProfiling):

File:

• trunk/Source/JavaScriptCore/profiler/LegacyProfiler.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/profiler/LegacyProfiler.cpp

@@ -64 +64 @@
     ASSERT_ARG(title, !title.isNull());
 
+    if (!exec)
+        return;
+
     // Check if we currently have a Profile for this global ExecState and title.
     // If so return early and don't create a new Profile.
-    JSGlobalObject* origin = exec ? exec->lexicalGlobalObject() : 0;
+    JSGlobalObject* origin = exec->lexicalGlobalObject();
 
     for (size_t i = 0; i < m_currentProfiles.size(); ++i) {
@@ -81 +84 @@
 PassRefPtr<Profile> LegacyProfiler::stopProfiling(ExecState* exec, const String& title)
 {
-    JSGlobalObject* origin = exec ? exec->lexicalGlobalObject() : 0;
+    if (!exec)
+        return 0;
+
+    JSGlobalObject* origin = exec->lexicalGlobalObject();
     for (ptrdiff_t i = m_currentProfiles.size() - 1; i >= 0; --i) {
         ProfileGenerator* profileGenerator = m_currentProfiles[i].get();