Changeset 144122 in webkit for trunk/Source/JavaScriptCore/parser/SourceProvider.h

Timestamp:

Feb 26, 2013, 4:38:14 PM (12 years ago)

Author:

[email protected]

Message:

Web Inspector: REGRESSION: [JSC] SourceProvider reuses IDs
​https://bugs.webkit.org/show_bug.cgi?id=99674

Reviewed by Gavin Barraclough.

Simple incrementing counter for SourceProvider IDs. Uses a
lock to incrementing the counter so we don't increment reuse
counter values or reassign the ID for a given SourceProvider.

• parser/SourceProvider.cpp:

(JSC::SourceProvider::SourceProvider):
(JSC):
(JSC::SourceProvider::getID):

• parser/SourceProvider.h:

(JSC::SourceProvider::asID):
(SourceProvider):

File:

• trunk/Source/JavaScriptCore/parser/SourceProvider.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/parser/SourceProvider.h

@@ -59 +59 @@
             if (!this) // Be defensive in release mode.
                 return nullID;
-            return reinterpret_cast<intptr_t>(this);
+            if (!m_id)
+                getID();
+            return m_id;
         }
 
@@ -67 +69 @@
     private:
 
+        JS_EXPORT_PRIVATE void getID();
+
         String m_url;
         TextPosition m_startPosition;
-        bool m_validated;
+        bool m_validated : 1;
+        uintptr_t m_id : sizeof(uintptr_t) * 8 - 1;
     };