Ignore:
Timestamp:
Mar 9, 2013, 2:48:09 PM (12 years ago)
Author:
[email protected]
Message:

Unreviewed, rolling out r145299.
http://trac.webkit.org/changeset/145299
https://bugs.webkit.org/show_bug.cgi?id=111928

compilation failure with recent clang
(DFGBackwardsPropagationPhase.cpp:132:35: error: comparison of
constant 10 with expression of type 'bool' is always false)
(Requested by thorton on #webkit).

Patch by Sheriff Bot <[email protected]> on 2013-03-09

Source/JavaScriptCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::refine):

  • dfg/DFGBackwardsPropagationPhase.cpp: Removed.
  • dfg/DFGBackwardsPropagationPhase.h: Removed.
  • dfg/DFGCPSRethreadingPhase.cpp:

(JSC::DFG::CPSRethreadingPhase::run):
(CPSRethreadingPhase):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocalFor):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGNodeFlags.cpp:

(JSC::DFG::nodeFlagsAsString):
(DFG):

  • dfg/DFGNodeFlags.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::isNotNegZero):
(PredictionPropagationPhase):
(JSC::DFG::PredictionPropagationPhase::isNotZero):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwoForConstant):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwoNonRecursive):
(JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwo):
(JSC::DFG::PredictionPropagationPhase::propagate):
(JSC::DFG::PredictionPropagationPhase::mergeDefaultFlags):

  • dfg/DFGUnificationPhase.cpp:

(JSC::DFG::UnificationPhase::run):

  • dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::VariableAccessData):
(VariableAccessData):

LayoutTests:

  • fast/js/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int-expected.txt: Removed.
  • fast/js/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.html: Removed.
  • fast/js/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers-expected.txt: Removed.
  • fast/js/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers.html: Removed.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.js: Removed.
  • fast/js/script-tests/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers.js: Removed.
File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r145299 r145323  
     12013-03-09  Sheriff Bot  <[email protected]>
     2
     3        Unreviewed, rolling out r145299.
     4        http://trac.webkit.org/changeset/145299
     5        https://bugs.webkit.org/show_bug.cgi?id=111928
     6
     7        compilation failure with recent clang
     8        (DFGBackwardsPropagationPhase.cpp:132:35: error: comparison of
     9        constant 10 with expression of type 'bool' is always false)
     10        (Requested by thorton on #webkit).
     11
     12        * CMakeLists.txt:
     13        * GNUmakefile.list.am:
     14        * JavaScriptCore.xcodeproj/project.pbxproj:
     15        * Target.pri:
     16        * dfg/DFGArrayMode.cpp:
     17        (JSC::DFG::ArrayMode::refine):
     18        * dfg/DFGBackwardsPropagationPhase.cpp: Removed.
     19        * dfg/DFGBackwardsPropagationPhase.h: Removed.
     20        * dfg/DFGCPSRethreadingPhase.cpp:
     21        (JSC::DFG::CPSRethreadingPhase::run):
     22        (CPSRethreadingPhase):
     23        (JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor):
     24        (JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocalFor):
     25        * dfg/DFGDriver.cpp:
     26        (JSC::DFG::compile):
     27        * dfg/DFGGraph.cpp:
     28        (JSC::DFG::Graph::dump):
     29        * dfg/DFGNodeFlags.cpp:
     30        (JSC::DFG::nodeFlagsAsString):
     31        (DFG):
     32        * dfg/DFGNodeFlags.h:
     33        (DFG):
     34        * dfg/DFGPredictionPropagationPhase.cpp:
     35        (JSC::DFG::PredictionPropagationPhase::isNotNegZero):
     36        (PredictionPropagationPhase):
     37        (JSC::DFG::PredictionPropagationPhase::isNotZero):
     38        (JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwoForConstant):
     39        (JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwoNonRecursive):
     40        (JSC::DFG::PredictionPropagationPhase::isWithinPowerOfTwo):
     41        (JSC::DFG::PredictionPropagationPhase::propagate):
     42        (JSC::DFG::PredictionPropagationPhase::mergeDefaultFlags):
     43        * dfg/DFGUnificationPhase.cpp:
     44        (JSC::DFG::UnificationPhase::run):
     45        * dfg/DFGVariableAccessData.h:
     46        (JSC::DFG::VariableAccessData::VariableAccessData):
     47        (VariableAccessData):
     48
    1492013-03-08  Filip Pizlo  <[email protected]>
    250
Note: See TracChangeset for help on using the changeset viewer.