Changeset 146383 in webkit for trunk/Source/JavaScriptCore/heap/GCThreadSharedData.cpp

Timestamp:

Mar 20, 2013, 1:43:31 PM (12 years ago)

Author:

[email protected]

Message:

It's called "Hash Consing" not "Hash Consting"
​https://bugs.webkit.org/show_bug.cgi?id=112768

Rubber stamped by Mark Hahnenberg.

See ​http://en.wikipedia.org/wiki/Hash_consing

• heap/GCThreadSharedData.cpp:

(JSC::GCThreadSharedData::GCThreadSharedData):
(JSC::GCThreadSharedData::reset):

• heap/GCThreadSharedData.h:

(GCThreadSharedData):

• heap/SlotVisitor.cpp:

(JSC::SlotVisitor::SlotVisitor):
(JSC::SlotVisitor::setup):
(JSC::SlotVisitor::reset):
(JSC::JSString::tryHashConsLock):
(JSC::JSString::releaseHashConsLock):
(JSC::JSString::shouldTryHashCons):
(JSC::SlotVisitor::internalAppend):

• heap/SlotVisitor.h:

(SlotVisitor):

• runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

• runtime/JSGlobalData.h:

(JSGlobalData):
(JSC::JSGlobalData::haveEnoughNewStringsToHashCons):
(JSC::JSGlobalData::resetNewStringsSinceLastHashCons):

• runtime/JSString.h:

(JSC::JSString::finishCreation):
(JSString):
(JSC::JSString::isHashConsSingleton):
(JSC::JSString::clearHashConsSingleton):
(JSC::JSString::setHashConsSingleton):

File:

• trunk/Source/JavaScriptCore/heap/GCThreadSharedData.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/heap/GCThreadSharedData.cpp

@@ -56 +56 @@
     : m_globalData(globalData)
     , m_copiedSpace(&globalData->heap.m_storageSpace)
-    , m_shouldHashConst(false)
+    , m_shouldHashCons(false)
     , m_sharedMarkStack(globalData->heap.blockAllocator())
     , m_numberOfActiveParallelMarkers(0)
@@ -116 +116 @@
     m_weakReferenceHarvesters.removeAll();
 
-    if (m_shouldHashConst) {
-        m_globalData->resetNewStringsSinceLastHashConst();
-        m_shouldHashConst = false;
+    if (m_shouldHashCons) {
+        m_globalData->resetNewStringsSinceLastHashCons();
+        m_shouldHashCons = false;
     }
 }