Changeset 146932 in webkit for trunk/Source/JavaScriptCore/profiler/ProfilerDatabase.h

Timestamp:

Mar 26, 2013, 2:43:27 PM (12 years ago)

Author:

[email protected]

Message:

JSC_enableProfiler=true should also cause JSGlobalData to save the profiler output somewhere
​https://bugs.webkit.org/show_bug.cgi?id=113144

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Added the ability to save profiler output with JSC_enableProfiler=true. It will save it
to the current directory, or JSC_PROFILER_PATH if the latter was specified.

This works by saving the Profiler::Database either when it is destroyed or atexit(),
whichever happens first.

This allows use of the profiler from any WebKit client.

• jsc.cpp:

(jscmain):

• profiler/ProfilerDatabase.cpp:

(Profiler):
(JSC::Profiler::Database::Database):
(JSC::Profiler::Database::~Database):
(JSC::Profiler::Database::registerToSaveAtExit):
(JSC::Profiler::Database::addDatabaseToAtExit):
(JSC::Profiler::Database::removeDatabaseFromAtExit):
(JSC::Profiler::Database::performAtExitSave):
(JSC::Profiler::Database::removeFirstAtExitDatabase):
(JSC::Profiler::Database::atExitCallback):

• profiler/ProfilerDatabase.h:

(JSC::Profiler::Database::databaseID):
(Database):

• runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

Source/WTF:

Reviewed by Geoffrey Garen.

I got tired of the fact that getpid(2) is not a syscall on Windows (unless you do
_getpid() I believe), so I wrote a header that abstracts it. I also changed existing
code that uses getpid() to use WTF::getCurrentProcessID().

• GNUmakefile.list.am:
• WTF.gypi:
• WTF.pro:
• WTF.vcproj/WTF.vcproj:
• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::dumpProfile):

• wtf/ProcessID.h: Added.

(WTF):
(WTF::getCurrentProcessID):

• wtf/text/StringImpl.cpp:

(WTF::StringStats::printStats):

File:

• trunk/Source/JavaScriptCore/profiler/ProfilerDatabase.h (modified) (3 diffs)

trunk/Source/JavaScriptCore/profiler/ProfilerDatabase.h

@@ -1 +1 @@
 /*
- * Copyright (C) 2012 Apple Inc. All rights reserved.
+ * Copyright (C) 2012, 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -46 +46 @@
     JS_EXPORT_PRIVATE ~Database();
     
+    int databaseID() const { return m_databaseID; }
+    
     Bytecodes* ensureBytecodesFor(CodeBlock*);
     void notifyDestruction(CodeBlock*);
@@ -66 +68 @@
     JS_EXPORT_PRIVATE bool save(const char* filename) const;
 
+    void registerToSaveAtExit(const char* filename);
+    
 private:
 
+    void addDatabaseToAtExit();
+    void removeDatabaseFromAtExit();
+    void performAtExitSave() const;
+    static Database* removeFirstAtExitDatabase();
+    static void atExitCallback();
+    
+    int m_databaseID;
     JSGlobalData& m_globalData;
     SegmentedVector<Bytecodes> m_bytecodes;
     HashMap<CodeBlock*, Bytecodes*> m_bytecodesMap;
     Vector<RefPtr<Compilation> > m_compilations;
+    bool m_shouldSaveAtExit;
+    CString m_atExitSaveFilename;
+    Database* m_nextRegisteredDatabase;
 };