Changeset 14728 in webkit for trunk/JavaScriptCore/wtf/HashMap.h

Timestamp:

Jun 4, 2006, 3:51:57 PM (19 years ago)

Author:

darin

Message:

Reviewed by Anders.

• changed deleteAllValues so it can work on "const" collections Deleting the values affects the values, not the pointers in the collection, so it's legitimate to do it to a const collection, and a case of that actually came up in the XPath code.

• wtf/HashMap.h: (WTF::deleteAllPairSeconds): Use const iterators. (WTF::deleteAllValues): Take const HashMap reference as a parameter.
• wtf/HashSet.h: (WTF::deleteAllValues): Take const HashSet reference as a parameter, and use const iterators.
• wtf/Vector.h: (WTF::deleteAllValues): Take const Vector reference as a parameter.

• added more functions that are present in <math.h> on some platforms, but not on others; moved here from various files in WebCore

• wtf/MathExtras.h: (isinf): Added. (isnan): Added. (lround): Added. (lroundf): Tweaked. (round): Added. (roundf): Tweaked. (signbit): Added.

File:

• trunk/JavaScriptCore/wtf/HashMap.h (modified) (2 diffs)

trunk/JavaScriptCore/wtf/HashMap.h

@@ -309 +309 @@
     void deleteAllPairSeconds(HashTableType& collection)
     {
-        typedef typename HashTableType::iterator iterator;
+        typedef typename HashTableType::const_iterator iterator;
         iterator end = collection.end();
         for (iterator it = collection.begin(); it != end; ++it)
@@ -316 +316 @@
 
     template<typename T, typename U, typename V, typename W, typename X>
-    inline void deleteAllValues(HashMap<T, U, V, W, X>& collection)
+    inline void deleteAllValues(const HashMap<T, U, V, W, X>& collection)
     {
         deleteAllPairSeconds<typename HashMap<T, U, V, W, X>::MappedType>(collection);