Changeset 14728 in webkit for trunk/JavaScriptCore/wtf/Vector.h

Timestamp:

Jun 4, 2006, 3:51:57 PM (19 years ago)

Author:

darin

Message:

Reviewed by Anders.

• changed deleteAllValues so it can work on "const" collections Deleting the values affects the values, not the pointers in the collection, so it's legitimate to do it to a const collection, and a case of that actually came up in the XPath code.

• wtf/HashMap.h: (WTF::deleteAllPairSeconds): Use const iterators. (WTF::deleteAllValues): Take const HashMap reference as a parameter.
• wtf/HashSet.h: (WTF::deleteAllValues): Take const HashSet reference as a parameter, and use const iterators.
• wtf/Vector.h: (WTF::deleteAllValues): Take const Vector reference as a parameter.

• added more functions that are present in <math.h> on some platforms, but not on others; moved here from various files in WebCore

• wtf/MathExtras.h: (isinf): Added. (isnan): Added. (lround): Added. (lroundf): Tweaked. (round): Added. (roundf): Tweaked. (signbit): Added.

File:

• trunk/JavaScriptCore/wtf/Vector.h (modified) (1 diff)

trunk/JavaScriptCore/wtf/Vector.h

@@ -580 +580 @@
 
     template<typename T, size_t inlineCapacity>
-    void deleteAllValues(Vector<T, inlineCapacity>& collection)
-    {
-        typedef Vector<T, inlineCapacity> Vec;
-        typename Vec::iterator end = collection.end();
-        for (typename Vec::iterator it = collection.begin(); it != end; ++it)
+    void deleteAllValues(const Vector<T, inlineCapacity>& collection)
+    {
+        typedef typename Vector<T, inlineCapacity>::const_iterator iterator;
+        iterator end = collection.end();
+        for (iterator it = collection.begin(); it != end; ++it)
             delete *it;
     }