Changeset 148949 in webkit for trunk/Source/WebCore/rendering/RenderHTMLCanvas.cpp

Timestamp:

Apr 23, 2013, 1:17:05 AM (12 years ago)

Author:

[email protected]

Message:

Respect image-rendering setting for determing image-rendering quality
​https://bugs.webkit.org/show_bug.cgi?id=113405

Reviewed by Benjamin Poulain.

Source/WebCore:

Remove the CSS4 values as they are not ready for implementation yet.
We still parse the -webkit-crisp-edges and SVG compatibility values to
be closer to the the partial support in Gecko and Presto.

Tests: fast/css/image-rendering-canvas.html

fast/css/image-rendering-parsing.html
fast/css/image-rendering.html
fast/css/optimize-contrast-image.html

• css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

• css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EImageRendering):

• css/CSSValueKeywords.in:
• css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

• rendering/RenderBoxModelObject.cpp:

(WebCore::ImageQualityController::shouldPaintAtLowQuality):

• rendering/RenderHTMLCanvas.cpp:

(WebCore::RenderHTMLCanvas::paintReplaced):

• rendering/style/RenderStyleConstants.h:

Tools:

Remove CSS4 Images option. It is not ready for implementation.

• Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Moved the two tests of image-rendering out of CSS3 since it was removed from the final recommendation.
Added tests of the supported values, and upgraded one test to a reference test so that it now tests
that -webkit-optimize-contrast gets converted to and treated as -webkit-crisp-edges.

Baselines for fast/css/image-rendering.html will be uploaded later when the bots have generated them.

• css3/images/optimize-contrast-image-expected.png: Removed.
• css3/images/optimize-contrast-image-expected.txt: Removed.
• fast/css/image-rendering-canvas-expected.png: Renamed from LayoutTests/css3/images/optimize-contrast-canvas-expected.png.
• fast/css/image-rendering-canvas-expected.txt: Renamed from LayoutTests/css3/images/optimize-contrast-canvas-expected.txt.
• fast/css/image-rendering-canvas.html: Renamed from LayoutTests/css3/images/optimize-contrast-canvas.html.
• fast/css/image-rendering-expected.txt: Added.
• fast/css/image-rendering-parsing-expected.txt: Added.
• fast/css/image-rendering-parsing.html: Renamed from LayoutTests/fast/css/image-set-parsing.html.
• fast/css/image-rendering.html: Added.
• fast/css/optimize-contrast-image-expected.html: Added.
• fast/css/optimize-contrast-image.html: Renamed from LayoutTests/css3/images/optimize-contrast-image.html.
• fast/css/script-tests/image-rendering-parsing.js: Added.

(testImageRendering):

File:

• trunk/Source/WebCore/rendering/RenderHTMLCanvas.cpp (modified) (1 diff)

trunk/Source/WebCore/rendering/RenderHTMLCanvas.cpp

@@ -69 +69 @@
     }
 
-    bool useLowQualityScale = style()->imageRendering() == ImageRenderingPixelated || style()->imageRendering() == ImageRenderingCrispEdges || style()->imageRendering() == ImageRenderingOptimizeSpeed;
+    bool useLowQualityScale = style()->imageRendering() == ImageRenderingCrispEdges || style()->imageRendering() == ImageRenderingOptimizeSpeed;
     static_cast<HTMLCanvasElement*>(node())->paint(paintInfo.context, rect, useLowQualityScale);
 }