Changeset 150659 in webkit for trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h

Timestamp:

May 24, 2013, 3:00:21 PM (12 years ago)

Author:

[email protected]

Message:

We broke !(0/0)
​https://bugs.webkit.org/show_bug.cgi?id=116736

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

• parser/ASTBuilder.h:

(JSC::ASTBuilder::createLogicalNot):

• runtime/JSCJSValueInlines.h:

(JSC::JSValue::pureToBoolean):

Source/WTF:

• wtf/MathExtras.h:

(isNotZeroAndOrdered):
(isZeroOrUnordered):

LayoutTests:

• fast/js/constant-fold-not-nan.html: Added.
• fast/js/constant-fold-not-nan-expected.txt: Added.
• fast/js/jsc-test-list:
• fast/js/script-tests/constant-fold-not-nan.js: Added.

File:

• trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h

@@ -799 +799 @@
         return asInt32() ? TrueTriState : FalseTriState;
     if (isDouble())
-        return (asDouble() > 0.0 || asDouble() < 0.0) ? TrueTriState : FalseTriState; // false for NaN
+        return isNotZeroAndOrdered(asDouble()) ? TrueTriState : FalseTriState; // false for NaN
     if (isCell())
         return asCell()->pureToBoolean();