Changeset 15155 in webkit for trunk/JavaScriptCore/kjs/operations.cpp

Timestamp:

Jul 4, 2006, 9:13:32 PM (19 years ago)

Author:

darin

Message:

Reviewed by Maciej.
Tweaked a bit by Darin.

• ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9678 work around MSVCRT's fmod function returning NaN for fmod(x, infinity) instead of x

• wtf/MathExtras.h: Added include of <float.h>. (isinf): Fix to return false for NAN. (wtf_fmod): Added. An inline that works around the bug.

• kjs/nodes.cpp:
• kjs/number_object.cpp:
• kjs/operations.cpp:
• kjs/value.cpp: Added includes of MathExtras.h to all files using fmod.

• JavaScriptCore.xcodeproj/project.pbxproj: Let Xcode 2.3 have its way with the project.

File:

• trunk/JavaScriptCore/kjs/operations.cpp (modified) (3 diffs)

trunk/JavaScriptCore/kjs/operations.cpp

@@ -24 +24 @@
 #include "operations.h"
 
+#include "object.h"
 #include <math.h>
 #include <stdio.h>
+#include <wtf/MathExtras.h>
 
 #if HAVE(FUNC_ISINF) && HAVE(IEEEFP_H)
@@ -35 +37 @@
 #endif
 
-#include "object.h"
-
 namespace KJS {
     
 #if !PLATFORM(DARWIN)
-// FIXME: should probably be inlined on other platforms too, and controlled exclusively
-// by HAVE macros
-    
-    
+
+// FIXME: Should probably be inlined on non-Darwin platforms too, and controlled exclusively
+// by HAVE macros rather than PLATFORM.
+
+// FIXME: Merge with isnan in MathExtras.h and remove this one entirely.
 bool isNaN(double d)
 {
@@ -55 +56 @@
 }
 
+// FIXME: Merge with isinf in MathExtras.h and remove this one entirely.
 bool isInf(double d)
 {