Changeset 15225 in webkit for trunk/JavaScriptCore/API/JSObjectRef.h

Timestamp:

Jul 7, 2006, 7:25:55 PM (19 years ago)

Author:

ggaren

Message:

Reviewed by Maciej.

• Standardized which functions take a JSContext as an argument. The rule is: if you might execute JavaScript, you take a JSContext, otherwise you don't.

The FIXME in JSObjectRef.h requires refactoring some parts of Interpreter,
but not API changes, so I'm putting it off until later.

• API/JSCallbackObject.cpp: (KJS::JSCallbackObject::JSCallbackObject): (KJS::JSCallbackObject::init):
• API/JSCallbackObject.h:
• API/JSContextRef.cpp: (JSContextCreate):
• API/JSContextRef.h:
• API/JSObjectRef.cpp: (JSObjectMake): (JSPropertyEnumeratorGetNext):
• API/JSObjectRef.h:
• API/testapi.c: (MyObject_initialize): (main):
• JavaScriptCore.exp:
• kjs/array_object.cpp: (ArrayInstance::setLength): (ArrayInstance::pushUndefinedObjectsToEnd):
• kjs/nodes.cpp: (ForInNode::execute):
• kjs/reference.cpp: (KJS::Reference::getPropertyName): (KJS::Reference::getValue):
• kjs/reference.h:
• kjs/scope_chain.cpp: (KJS::ScopeChain::print):

File:

• trunk/JavaScriptCore/API/JSObjectRef.h (modified) (2 diffs)

trunk/JavaScriptCore/API/JSObjectRef.h

@@ -58 +58 @@
 @typedef JSInitializeCallback
 @abstract The callback invoked when an object is first created.
+@param context The execution context to use.
 @param object The JSObject being created.
 @discussion If you named your function Initialize, you would declare it like this:
 
-void Initialize(JSObjectRef object);
-*/
-
-// FIXME: Needs to take a context argument, but can't because no context exists when we're creating the global object
+void Initialize(JSContextRef context, JSObjectRef object);
+*/
 typedef void
-(*JSInitializeCallback)         (JSObjectRef object);
+(*JSInitializeCallback)         (JSContextRef context, JSObjectRef object);
 
 /*! 
@@ -493 +492 @@
 @function
 @abstract Gets a property enumerator's next property.
-@param context The execution context to use.
 @param enumerator The JSPropertyEnumerator whose next property you want to get.
 @result A JSStringBuffer containing the property's name, or NULL if all properties have been enumerated.
 */
-JSStringBufferRef JSPropertyEnumeratorGetNext(JSContextRef context, JSPropertyEnumeratorRef enumerator);
+JSStringBufferRef JSPropertyEnumeratorGetNext(JSPropertyEnumeratorRef enumerator);
 
 /*!