Changeset 15225 in webkit for trunk/JavaScriptCore/kjs/array_object.cpp

Timestamp:

Jul 7, 2006, 7:25:55 PM (19 years ago)

Author:

ggaren

Message:

Reviewed by Maciej.

• Standardized which functions take a JSContext as an argument. The rule is: if you might execute JavaScript, you take a JSContext, otherwise you don't.

The FIXME in JSObjectRef.h requires refactoring some parts of Interpreter,
but not API changes, so I'm putting it off until later.

• API/JSCallbackObject.cpp: (KJS::JSCallbackObject::JSCallbackObject): (KJS::JSCallbackObject::init):
• API/JSCallbackObject.h:
• API/JSContextRef.cpp: (JSContextCreate):
• API/JSContextRef.h:
• API/JSObjectRef.cpp: (JSObjectMake): (JSPropertyEnumeratorGetNext):
• API/JSObjectRef.h:
• API/testapi.c: (MyObject_initialize): (main):
• JavaScriptCore.exp:
• kjs/array_object.cpp: (ArrayInstance::setLength): (ArrayInstance::pushUndefinedObjectsToEnd):
• kjs/nodes.cpp: (ForInNode::execute):
• kjs/reference.cpp: (KJS::Reference::getPropertyName): (KJS::Reference::getValue):
• kjs/reference.h:
• kjs/scope_chain.cpp: (KJS::ScopeChain::print):

File:

• trunk/JavaScriptCore/kjs/array_object.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/array_object.cpp

@@ -252 +252 @@
       Reference ref = it++;
       bool ok;
-      unsigned index = ref.getPropertyName(exec).toArrayIndex(&ok);
+      unsigned index = ref.getPropertyName().toArrayIndex(&ok);
       if (ok && index > newLength) {
         ref.deleteValue(exec);
@@ -374 +374 @@
       Reference ref = it++;
       storage[o] = ref.getValue(exec);
-      JSObject::deleteProperty(exec, ref.getPropertyName(exec));
+      JSObject::deleteProperty(exec, ref.getPropertyName());
       o++;
     }