Changeset 15307 in webkit for trunk/JavaScriptCore/API/JSNode.c

Timestamp:

Jul 10, 2006, 10:41:32 AM (19 years ago)

Author:

ggaren

Message:

Approved by Maciej, Darin.

Renamed JSStringBufferRef to JSInternalStringRef. "Internal string" means the
JavaScript engine's internal string representation, which is the most
low-level and efficient representation to use when interfacing with JavaScript.

• API/APICast.h: (toJS): (toRef):
• API/JSBase.h:
• API/JSCallbackObject.cpp: (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::deleteProperty): (KJS::JSCallbackObject::staticValueGetter): (KJS::JSCallbackObject::callbackGetter):
• API/JSContextRef.cpp: (JSEvaluate): (JSCheckSyntax):
• API/JSContextRef.h:
• API/JSInternalStringRef.cpp: Added. (JSStringMake): (JSInternalStringCreate): (JSInternalStringCreateUTF8): (JSInternalStringRetain): (JSInternalStringRelease): (JSValueCopyStringValue): (JSInternalStringGetLength): (JSInternalStringGetCharactersPtr): (JSInternalStringGetCharacters): (JSInternalStringGetMaxLengthUTF8): (JSInternalStringGetCharactersUTF8): (JSInternalStringIsEqual): (JSInternalStringIsEqualUTF8): (JSInternalStringCreateCF): (CFStringCreateWithJSInternalString):
• API/JSInternalStringRef.h: Added.
• API/JSNode.c: (JSNodePrototype_appendChild): (JSNode_getNodeType): (JSNode_getChildNodes): (JSNode_getFirstChild):
• API/JSNodeList.c: (JSNodeList_length): (JSNodeList_getProperty):
• API/JSObjectRef.cpp: (JSFunctionMakeWithBody): (JSObjectGetDescription): (JSObjectHasProperty): (JSObjectGetProperty): (JSObjectSetProperty): (JSObjectDeleteProperty): (JSPropertyEnumeratorGetNext): (JSPropertyListAdd):
• API/JSObjectRef.h:
• API/JSStringBufferRef.cpp: Removed.
• API/JSStringBufferRef.h: Removed.
• API/JSValueRef.h:
• API/JavaScriptCore.h:
• API/minidom.c: (main): (print):
• API/testapi.c: (assertEqualsAsUTF8String): (assertEqualsAsCharactersPtr): (assertEqualsAsCharacters): (MyObject_hasProperty): (MyObject_getProperty): (MyObject_setProperty): (MyObject_deleteProperty): (MyObject_getPropertyList): (print_callAsFunction): (myConstructor_callAsConstructor): (main):
• JavaScriptCore.exp:
• JavaScriptCore.xcodeproj/project.pbxproj:

File:

• trunk/JavaScriptCore/API/JSNode.c (modified) (5 diffs)

trunk/JavaScriptCore/API/JSNode.c

@@ -40 +40 @@
     // Example of throwing a type error for invalid values
     if (!JSValueIsObjectOfClass(thisObject, JSNode_class(context))) {
-        JSStringBufferRef messageBuf = JSStringBufferCreateUTF8("TypeError: appendChild can only be called on nodes");
+        JSInternalStringRef messageBuf = JSInternalStringCreateUTF8("TypeError: appendChild can only be called on nodes");
         JSContextSetException(context, JSStringMake(messageBuf));
-        JSStringBufferRelease(messageBuf);
+        JSInternalStringRelease(messageBuf);
     } else if (argc < 1 || !JSValueIsObjectOfClass(argv[0], JSNode_class(context))) {
-        JSStringBufferRef messageBuf = JSStringBufferCreateUTF8("TypeError: first argument to appendChild must be a node");
+        JSInternalStringRef messageBuf = JSInternalStringCreateUTF8("TypeError: first argument to appendChild must be a node");
         JSContextSetException(context, JSStringMake(messageBuf));
-        JSStringBufferRelease(messageBuf);
+        JSInternalStringRelease(messageBuf);
     } else {
         Node* node = JSObjectGetPrivate(thisObject);
@@ -114 +114 @@
 }
 
-static bool JSNode_getNodeType(JSContextRef context, JSObjectRef object, JSStringBufferRef propertyName, JSValueRef* returnValue)
+static bool JSNode_getNodeType(JSContextRef context, JSObjectRef object, JSInternalStringRef propertyName, JSValueRef* returnValue)
 {
     UNUSED_PARAM(context);
@@ -121 +121 @@
     Node* node = JSObjectGetPrivate(object);
     if (node) {
-        JSStringBufferRef nodeBuf = JSStringBufferCreateUTF8(node->nodeType);
+        JSInternalStringRef nodeBuf = JSInternalStringCreateUTF8(node->nodeType);
         *returnValue = JSStringMake(nodeBuf);
-        JSStringBufferRelease(nodeBuf);
+        JSInternalStringRelease(nodeBuf);
         return true;
     }
@@ -129 +129 @@
 }
 
-static bool JSNode_getChildNodes(JSContextRef context, JSObjectRef thisObject, JSStringBufferRef propertyName, JSValueRef* returnValue)
+static bool JSNode_getChildNodes(JSContextRef context, JSObjectRef thisObject, JSInternalStringRef propertyName, JSValueRef* returnValue)
 {
     UNUSED_PARAM(propertyName);
@@ -138 +138 @@
 }
 
-static bool JSNode_getFirstChild(JSContextRef context, JSObjectRef object, JSStringBufferRef propertyName, JSValueRef* returnValue)
+static bool JSNode_getFirstChild(JSContextRef context, JSObjectRef object, JSInternalStringRef propertyName, JSValueRef* returnValue)
 {
     UNUSED_PARAM(context);