Changeset 15310 in webkit for trunk/JavaScriptCore/kjs

Timestamp:

Jul 10, 2006, 2:17:26 PM (19 years ago)

Author:

ggaren

Message:

Reviewed by Darin.

Improved type safety by implementing opaque JSValue/JSObject typing through
abuse of 'const', not void*. Also fixed an alarming number of bugs
exposed by this new type safety.

I made one design change in JavaScriptCore, which is that the JSObject
constructor should take a JSValue* as its prototype argument, not a JSObject*,
since we allow the prototype to be any JSValue*, including jsNull(), for
example.

• API/APICast.h: (toJS):
• API/JSBase.h:
• API/JSCallbackConstructor.cpp: (KJS::JSCallbackConstructor::construct):
• API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::callAsFunction):
• API/JSCallbackObject.cpp: (KJS::JSCallbackObject::JSCallbackObject): (KJS::JSCallbackObject::getOwnPropertySlot): (KJS::JSCallbackObject::put): (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::callAsFunction): (KJS::JSCallbackObject::staticFunctionGetter):
• API/JSCallbackObject.h:
• API/JSContextRef.cpp: (JSEvaluate):
• API/JSNode.c: (JSNodePrototype_appendChild): (JSNodePrototype_removeChild): (JSNodePrototype_replaceChild):
• API/JSObjectRef.cpp: (JSObjectMake): (JSFunctionMakeWithBody): (JSObjectGetProperty): (JSObjectCallAsFunction): (JSObjectCallAsConstructor):
• API/JSObjectRef.h:
• API/testapi.c: (main):
• ChangeLog:
• kjs/object.h: (KJS::JSObject::JSObject):

File:

• trunk/JavaScriptCore/kjs/object.h (modified) (2 diffs)

trunk/JavaScriptCore/kjs/object.h

@@ -106 +106 @@
      * @param proto The prototype
      */
-    JSObject(JSObject *proto, bool destructorIsThreadSafe = true);
+    JSObject(JSValue* proto, bool destructorIsThreadSafe = true);
 
     /**
@@ -568 +568 @@
 JSObject *throwError(ExecState *, ErrorType);
 
-inline JSObject::JSObject(JSObject *proto, bool destructorIsThreadSafe)
+inline JSObject::JSObject(JSValue* proto, bool destructorIsThreadSafe)
     : JSCell(destructorIsThreadSafe)
     , _proto(proto)