Changeset 153143 in webkit for trunk/Source/JavaScriptCore/profiler/ProfilerDatabase.cpp

Timestamp:

Jul 24, 2013, 8:59:31 PM (12 years ago)

Author:

[email protected]

Message:

fourthTier: Profiler should be thread-safe
​https://bugs.webkit.org/show_bug.cgi?id=115445

Reviewed by Geoffrey Garen.

Change the Profiler::Database API for Compilation creation so that we don't add
it to the Database until it's completely constructed. This prevents the Database
from seeing Compilations that are being concurrently constructed.

Change the Profiler::Database itself to do locking for creation of Bytecodes and
for modifying the map. This map may be consulted by both the main thread and the
concurrent thread.

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::linkFunction):

• jit/JIT.cpp:

(JSC::JIT::privateCompile):

• profiler/ProfilerBytecodes.h:
• profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::ensureBytecodesFor):
(JSC::Profiler::Database::notifyDestruction):
(JSC::Profiler::Database::addCompilation):

• profiler/ProfilerDatabase.h:

(Database):

File:

• trunk/Source/JavaScriptCore/profiler/ProfilerDatabase.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/profiler/ProfilerDatabase.cpp

@@ -61 +61 @@
 Bytecodes* Database::ensureBytecodesFor(CodeBlock* codeBlock)
 {
+    Locker locker(m_lock);
+    
     codeBlock = codeBlock->baselineVersion();
     
@@ -77 +79 @@
 void Database::notifyDestruction(CodeBlock* codeBlock)
 {
+    Locker locker(m_lock);
+    
     m_bytecodesMap.remove(codeBlock);
 }
 
-PassRefPtr<Compilation> Database::newCompilation(Bytecodes* bytecodes, CompilationKind kind)
+void Database::addCompilation(PassRefPtr<Compilation> compilation)
 {
-    RefPtr<Compilation> compilation = adoptRef(new Compilation(bytecodes, kind));
+    ASSERT(!isCompilationThread());
+    
     m_compilations.append(compilation);
-    return compilation.release();
-}
-
-PassRefPtr<Compilation> Database::newCompilation(CodeBlock* codeBlock, CompilationKind kind)
-{
-    return newCompilation(ensureBytecodesFor(codeBlock), kind);
 }