Changeset 15321 in webkit for trunk/JavaScriptCore/kjs/value.cpp

Timestamp:

Jul 10, 2006, 8:16:41 PM (19 years ago)

Author:

ddkilzer

Message:

JavaScriptCore:

Reviewed by Darin.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9179 Implement select.options.add() method

• JavaScriptCore.exp: Added overloaded KJS::JSValue::toInt32() method.
• JavaScriptCore.xcodeproj/project.pbxproj: Altered attributes metadata for kjs/value.h to make it available as a forwarded header.
• kjs/lookup.h: (KJS::lookupPut): Extracted a lookupPut() method from the existing lookupPut() method. The new method returns a boolean value if no entry is found in the lookup table.
• kjs/value.cpp: (KJS::JSValue::toInt32): Overloaded toInt32() method with boolean "Ok" argument.
• kjs/value.h: Ditto.

LayoutTests:

Reviewed by Darin.

• test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9179 Implement select.options.add() method

• fast/dom/select-selectedIndex-multiple-expected.txt: Updated test results.
• fast/dom/select-selectedIndex-multiple.html: Updated to print comments between tests to make failures easier to track down.
• fast/dom/select-selectedIndex-expected.txt: Mirrored updates from select-selectedIndex-multiple.html
• fast/dom/select-selectedIndex.html: Ditto.
• fast/js/resources/select-options-add.js: Added.
• fast/js/select-options-add-expected.txt: Added.
• fast/js/select-options-add.html: Added.

WebCore:

Reviewed by Darin.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9179 Implement select.options.add() method

Tests:

• fast/dom/select-selectedIndex-multiple.html
• fast/dom/select-selectedIndex.html
• fast/js/select-options-add.html

• DerivedSources.make: Added JSHTMLOptionsCollection.h.
• ForwardingHeaders/kjs/operations.h: Added.
• WebCore.xcodeproj/project.pbxproj: Added new source files.
• bindings/js/JSHTMLOptionsCollectionCustom.cpp: Added. (WebCore::JSHTMLOptionsCollection::length): (WebCore::JSHTMLOptionsCollection::setLength): (WebCore::JSHTMLOptionsCollection::indexSetter):
• bindings/js/kjs_html.cpp: Removed JSHTMLOptionsCollection implementation. Renamed classes and methods for consistency. (KJS::JSHTMLElement::selectGetter): (KJS::JSHTMLElement::put): (KJS::JSHTMLElement::selectSetter): (KJS::JSHTMLCollection::JSHTMLCollection): (KJS::JSHTMLCollectionProtoFunc::callAsFunction): (KJS::getHTMLOptionsCollection):
• bindings/js/kjs_html.h: Ditto.
• bindings/scripts/CodeGeneratorJS.pm: Added support for HasCustomIndexSetter class attribute. Added support for Optional parameter attribute, which makes generated code assume overloaded implementation methods are available for a JavaScript function with optional arguments. Changed local 'impl' variables to 'imp' so that impl() methods could be called without class designation.
• html/HTMLOptionElement.idl: Added GenerateNativeConverter attribute.
• html/HTMLOptionsCollection.cpp: Added methods used by generated JSHTMLOptionsCollection class. (WebCore::HTMLOptionsCollection::HTMLOptionsCollection): (WebCore::HTMLOptionsCollection::add): (WebCore::HTMLOptionsCollection::selectedIndex): (WebCore::HTMLOptionsCollection::setSelectedIndex): (WebCore::HTMLOptionsCollection::setLength):
• html/HTMLOptionsCollection.h: Ditto.
• html/HTMLOptionsCollection.idl: Added.

File:

• trunk/JavaScriptCore/kjs/value.cpp (modified) (2 diffs)

trunk/JavaScriptCore/kjs/value.cpp

@@ -56 +56 @@
 }
 
-int32_t JSValue::toInt32(ExecState *exec) const
+int32_t JSValue::toInt32(ExecState* exec, bool& ok) const
 {
+    ok = true;
+
     uint32_t i;
     if (getUInt32(i))
@@ -63 +65 @@
 
     double d = roundValue(exec, const_cast<JSValue*>(this));
-    if (isNaN(d) || isInf(d))
+    if (isNaN(d) || isInf(d)) {
+        ok = false;
         return 0;
+    }
     double d32 = fmod(d, D32);