Changeset 153220 in webkit for trunk/Source/JavaScriptCore/dfg/DFGArrayMode.h

Timestamp:

Jul 24, 2013, 9:02:32 PM (12 years ago)

Author:

[email protected]

Message:

fourthTier: isContravenedByStructure is backwards
​https://bugs.webkit.org/show_bug.cgi?id=117366

We should be checking if arrayModeForStructure(structure) is a
subset of arrayModesThatPassFiltering(), not the other way around.
Also renamed isContravenedByStructure to better reflect what the
function is trying to determine.

Rubber stamped by Filip Pizlo.

• dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::structureWouldPassArrayModeFiltering):

• dfg/DFGTypeCheckHoistingPhase.cpp:

(JSC::DFG::TypeCheckHoistingPhase::noticeStructureCheckAccountingForArrayMode):
(JSC::DFG::ArrayTypeCheck::isContravenedByValue):

File:

• trunk/Source/JavaScriptCore/dfg/DFGArrayMode.h (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGArrayMode.h

@@ -369 +369 @@
     }
 
-    bool isContravenedByStructure(Structure* structure)
-    {
-        return !arrayModesAlreadyChecked(arrayModesThatPassFiltering(), arrayModeFromStructure(structure));
+    bool structureWouldPassArrayModeFiltering(Structure* structure)
+    {
+        return arrayModesAlreadyChecked(arrayModeFromStructure(structure), arrayModesThatPassFiltering());
     }