Changeset 153223 in webkit for trunk/Source/JavaScriptCore/runtime/JSObject.cpp

Timestamp:

Jul 24, 2013, 9:02:47 PM (12 years ago)

Author:

[email protected]

Message:

fourthTier: The Math object should not be polymorphic
​https://bugs.webkit.org/show_bug.cgi?id=117576

Reviewed by Oliver Hunt.

Fill in the Math object eagerly, to avoid its structure changing during
execution. There are lots of ways to skin this cat; this one seemed
easiest, and justified given the relative hotness of math operations.

20% speedup on DSP-filtrr tests, small speedups on a few Kraken tests.

• DerivedSources.make:
• JavaScriptCore.order:
• create_hash_table:
• interpreter/CallFrame.h:

(JSC::ExecState::jsonTable): Removed the Math object's static table.

• runtime/JSObject.cpp:

(JSC::JSObject::putDirectNativeFunctionWithoutTransition):

• runtime/JSObject.h:
• runtime/MathObject.cpp:

(JSC::MathObject::finishCreation):

• runtime/MathObject.h:

(JSC::MathObject::create): Set up the Math object at construction time.

• runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::~VM):

• runtime/VM.h: Removed the Math object's static table.

File:

• trunk/Source/JavaScriptCore/runtime/JSObject.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSObject.cpp

@@ -2200 +2200 @@
     ASSERT(name);
     
-    JSFunction* function =
-        JSFunction::create(exec, globalObject, functionLength, name, nativeFunction, intrinsic);
+    JSFunction* function = JSFunction::create(exec, globalObject, functionLength, name, nativeFunction, intrinsic);
     putDirect(exec->vm(), propertyName, function, attributes);
+}
+
+void JSObject::putDirectNativeFunctionWithoutTransition(ExecState* exec, JSGlobalObject* globalObject, const PropertyName& propertyName, unsigned functionLength, NativeFunction nativeFunction, Intrinsic intrinsic, unsigned attributes)
+{
+    StringImpl* name = propertyName.publicName();
+    ASSERT(name);
+    
+    JSFunction* function = JSFunction::create(exec, globalObject, functionLength, name, nativeFunction, intrinsic);
+    putDirectWithoutTransition(exec->vm(), propertyName, function, attributes);
 }