Changeset 153229 in webkit for trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h

Timestamp:

Jul 24, 2013, 9:03:03 PM (12 years ago)

Author:

[email protected]

Message:

fourthTier: Add CFG simplification for Switch
​https://bugs.webkit.org/show_bug.cgi?id=117677

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

This is for completeness. It only speeds up a microbenchmark at this point.
Broadly, we want all control constructs to be known to the CFG simplifier.

• dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::convertToJump):
(CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::noBlocks):
(JSC::DFG::CFGSimplificationPhase::oneBlock):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

• runtime/JSCJSValue.h:

(JSValue):

• runtime/JSCJSValueInlines.h:

(JSC::JSValue::pureStrictEqual):
(JSC):

Source/WTF:

Reviewed by Mark Hahnenberg.

• wtf/TriState.h:
• wtf/text/StringImpl.h:

LayoutTests:

Reviewed by Mark Hahnenberg.

• fast/js/regress/script-tests/switch-constant.js: Added.

(foo):
(bar):

• fast/js/regress/script-tests/switch.js: Added.

(foo):
(bar):

• fast/js/regress/switch-constant-expected.txt: Added.
• fast/js/regress/switch-constant.html: Added.
• fast/js/regress/switch-expected.txt: Added.
• fast/js/regress/switch.html: Added.

File:

• trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSCJSValueInlines.h

@@ -794 +794 @@
 }
 
+inline TriState JSValue::pureStrictEqual(JSValue v1, JSValue v2)
+{
+    if (v1.isInt32() && v2.isInt32())
+        return triState(v1 == v2);
+
+    if (v1.isNumber() && v2.isNumber())
+        return triState(v1.asNumber() == v2.asNumber());
+
+    if (!v1.isCell() || !v2.isCell())
+        return triState(v1 == v2);
+    
+    if (v1.asCell()->isString() && v2.asCell()->isString()) {
+        const StringImpl* v1String = asString(v1)->tryGetValueImpl();
+        const StringImpl* v2String = asString(v2)->tryGetValueImpl();
+        if (!v1String || !v2String)
+            return MixedTriState;
+        return triState(WTF::equal(v1String, v2String));
+    }
+    
+    return triState(v1 == v2);
+}
+
 inline TriState JSValue::pureToBoolean() const
 {