Changeset 153238 in webkit for trunk/Source/JavaScriptCore/runtime/JSCJSValue.cpp

Timestamp:

Jul 24, 2013, 9:03:25 PM (12 years ago)

Author:

[email protected]

Message:

fourthTier: Structure should have a dump()
​https://bugs.webkit.org/show_bug.cgi?id=117859

Reviewed by Geoffrey Garen.

This is pretty cool. Anywhere we previously printed Structure pointers in dumps,
we now print a bunch of other info as well. For example, for an object literal
like "{f:42, g:64, h:24}", when we print the structure we'll now get:

0x107a0af80:[Object, {f:0, g:1, h:2}, NonArray, Proto:0x107a8fff0]

This also changes a bunch of places to use the dump method.

• bytecode/StructureSet.h:

(JSC::StructureSet::dump):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

• dfg/DFGStructureAbstractValue.h:

(JSC::DFG::StructureAbstractValue::dump):

• runtime/JSCJSValue.cpp:

(JSC::JSValue::dump):

• runtime/Structure.cpp:

(JSC::Structure::dump):
(JSC):

• runtime/Structure.h:

(Structure):

File:

• trunk/Source/JavaScriptCore/runtime/JSCJSValue.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/JSCJSValue.cpp

@@ -217 +217 @@
                 out.print(" (unresolved)");
             out.print(": ", impl);
-        } else if (asCell()->inherits(&Structure::s_info)) {
-            Structure* structure = jsCast<Structure*>(asCell());
-            out.print(
-                "Structure: ", RawPointer(structure), ": ", structure->classInfo()->className,
-                ", ", IndexingTypeDump(structure->indexingTypeIncludingHistory()));
-        } else {
+        } else if (asCell()->inherits(&Structure::s_info))
+            out.print("Structure: ", *jsCast<Structure*>(asCell()));
+        else {
             out.print("Cell: ", RawPointer(asCell()));
             if (isObject() && asObject(*this)->butterfly())
                 out.print("->", RawPointer(asObject(*this)->butterfly()));
-            out.print(
-                " (", RawPointer(asCell()->structure()), ": ", asCell()->structure()->classInfo()->className,
-                ", ", IndexingTypeDump(asCell()->structure()->indexingTypeIncludingHistory()), ")");
+            out.print(" (", *asCell()->structure(), ")");
         }
     } else if (isTrue())