Changeset 153240 in webkit for trunk/Source/JavaScriptCore/runtime/JSString.h

Timestamp:

Jul 24, 2013, 9:03:30 PM (12 years ago)

Author:

[email protected]

Message:

fourthTier: Small strings shouldn't get GC'd
​https://bugs.webkit.org/show_bug.cgi?id=117897

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

Kill off the code needed to allocate them lazily and finalize them.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

• heap/Heap.cpp:

(JSC::Heap::collect):

• runtime/JSString.h:

(JSC::jsSingleCharacterString):
(JSC::jsSingleCharacterSubstring):
(JSC::jsString):
(JSC::jsSubstring8):
(JSC::jsSubstring):
(JSC::jsOwnedString):

• runtime/NumberPrototype.cpp:

(JSC::integerValueToString):

• runtime/SmallStrings.cpp:

(JSC):
(JSC::SmallStrings::initializeCommonStrings):
(JSC::SmallStrings::visitStrongReferences):

• runtime/SmallStrings.h:

(JSC::SmallStrings::singleCharacterString):
(SmallStrings):

LayoutTests:

Reviewed by Mark Hahnenberg.

This test speeds up by 5%.

• fast/js/regress/script-tests/string-get-by-val.js: Added.

(foo):

• fast/js/regress/string-get-by-val-expected.txt: Added.
• fast/js/regress/string-get-by-val.html: Added.

File:

• trunk/Source/JavaScriptCore/runtime/JSString.h (modified) (6 diffs)

trunk/Source/JavaScriptCore/runtime/JSString.h

@@ -352 +352 @@
     {
         if (c <= maxSingleCharacterString)
-            return vm->smallStrings.singleCharacterString(vm, c);
+            return vm->smallStrings.singleCharacterString(c);
         return JSString::create(*vm, String(&c, 1).impl());
     }
@@ -362 +362 @@
         UChar c = s.characterAt(offset);
         if (c <= maxSingleCharacterString)
-            return vm->smallStrings.singleCharacterString(vm, c);
+            return vm->smallStrings.singleCharacterString(c);
         return JSString::create(*vm, StringImpl::create(s.impl(), offset, 1));
     }
@@ -403 +403 @@
             UChar c = s.characterAt(0);
             if (c <= maxSingleCharacterString)
-                return vm->smallStrings.singleCharacterString(vm, c);
+                return vm->smallStrings.singleCharacterString(c);
         }
         return JSString::create(*vm, s.impl());
@@ -429 +429 @@
             UChar c = s.characterAt(offset);
             if (c <= maxSingleCharacterString)
-                return vm->smallStrings.singleCharacterString(vm, c);
+                return vm->smallStrings.singleCharacterString(c);
         }
         return JSString::createHasOtherOwner(*vm, StringImpl::create8(s.impl(), offset, length));
@@ -444 +444 @@
             UChar c = s.characterAt(offset);
             if (c <= maxSingleCharacterString)
-                return vm->smallStrings.singleCharacterString(vm, c);
+                return vm->smallStrings.singleCharacterString(c);
         }
         return JSString::createHasOtherOwner(*vm, StringImpl::create(s.impl(), offset, length));
@@ -457 +457 @@
             UChar c = s.characterAt(0);
             if (c <= maxSingleCharacterString)
-                return vm->smallStrings.singleCharacterString(vm, c);
+                return vm->smallStrings.singleCharacterString(c);
         }
         return JSString::createHasOtherOwner(*vm, s.impl());