Changeset 153283 in webkit for trunk/Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.h

Timestamp:

Jul 24, 2013, 9:05:04 PM (12 years ago)

Author:

[email protected]

Message:

fourthTier: AbstractInterpreter should explicitly ask AbstractState to create new AbstractValues for newly born nodes
​https://bugs.webkit.org/show_bug.cgi?id=118880

Reviewed by Sam Weinig.

It should be possible to have an AbstractState that is backed by a HashMap. But to
do this, the AbstractInterpreter should explicitly ask for new nodes to be added to
the map, since otherwise the idiom of getting a reference to the AbstractValue
returned by forNode() would cause really subtle memory corruption bugs.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

• dfg/DFGInPlaceAbstractState.h:

(JSC::DFG::InPlaceAbstractState::createValueForNode):
(InPlaceAbstractState):

File:

• trunk/Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.h (modified) (1 diff)

trunk/Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.h

@@ -44 +44 @@
     
     ~InPlaceAbstractState();
+    
+    void createValueForNode(Node*) { }
     
     AbstractValue& forNode(Node* node)