Changeset 153673 in webkit for trunk/Source/JavaScriptCore/runtime/Arguments.cpp

Timestamp:

Aug 2, 2013, 3:30:48 PM (12 years ago)

Author:

[email protected]

Message:

Remove no-arguments constructor to PropertySlot
​https://bugs.webkit.org/show_bug.cgi?id=119460

Reviewed by Geoff Garen.

This constructor was unsafe if getValue is subsequently called,
and the property is a getter. Simplest to just remove it.

• runtime/Arguments.cpp:

(JSC::Arguments::defineOwnProperty):

• runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnPropertyDescriptor):

• runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnNonIndexPropertyNames):
(JSC::JSFunction::put):
(JSC::JSFunction::defineOwnProperty):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::defineOwnProperty):

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::hasOwnPropertyForWrite):

• runtime/JSNameScope.cpp:

(JSC::JSNameScope::put):

• runtime/JSONObject.cpp:

(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):

• runtime/JSObject.cpp:

(JSC::JSObject::hasProperty):
(JSC::JSObject::hasOwnProperty):
(JSC::JSObject::reifyStaticFunctionsForDelete):

• runtime/Lookup.h:

(JSC::getStaticPropertyDescriptor):
(JSC::getStaticFunctionDescriptor):
(JSC::getStaticValueDescriptor):

• runtime/ObjectConstructor.cpp:

(JSC::defineProperties):

• runtime/PropertySlot.h:

File:

• trunk/Source/JavaScriptCore/runtime/Arguments.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/runtime/Arguments.cpp

@@ -288 +288 @@
         RELEASE_ASSERT(i < PropertyName::NotAnIndex);
         // If the property is not yet present on the object, and is not yet marked as deleted, then add it now.
-        PropertySlot slot;
+        PropertySlot slot(thisObject);
         if (!thisObject->isDeletedArgument(i) && !JSObject::getOwnPropertySlot(thisObject, exec, propertyName, slot)) {
             JSValue value = thisObject->tryGetArgument(i);