Ignore:
Timestamp:
Aug 2, 2013, 3:30:48 PM (12 years ago)
Author:
[email protected]
Message:

Remove no-arguments constructor to PropertySlot
​https://bugs.webkit.org/show_bug.cgi?id=119460

Reviewed by Geoff Garen.

This constructor was unsafe if getValue is subsequently called,
and the property is a getter. Simplest to just remove it.

  • runtime/Arguments.cpp:

(JSC::Arguments::defineOwnProperty):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnPropertyDescriptor):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnNonIndexPropertyNames):
(JSC::JSFunction::put):
(JSC::JSFunction::defineOwnProperty):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::defineOwnProperty):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::hasOwnPropertyForWrite):

  • runtime/JSNameScope.cpp:

(JSC::JSNameScope::put):

  • runtime/JSONObject.cpp:

(JSC::Stringifier::Holder::appendNextProperty):
(JSC::Walker::walk):

  • runtime/JSObject.cpp:

(JSC::JSObject::hasProperty):
(JSC::JSObject::hasOwnProperty):
(JSC::JSObject::reifyStaticFunctionsForDelete):

  • runtime/Lookup.h:

(JSC::getStaticPropertyDescriptor):
(JSC::getStaticFunctionDescriptor):
(JSC::getStaticValueDescriptor):

  • runtime/ObjectConstructor.cpp:

(JSC::defineProperties):

  • runtime/PropertySlot.h:
File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/runtime/JSActivation.cpp

    r153532 r153673  
    185185        // Defend against the inspector asking for the arguments object after it has been optimized out.
    186186        if (!thisObject->isTornOff()) {
    187             PropertySlot slot;
     187            PropertySlot slot(thisObject);
    188188            JSActivation::getOwnPropertySlot(thisObject, exec, propertyName, slot);
    189189            descriptor.setDescriptor(slot.getValue(exec, propertyName), DontEnum);
Note: See TracChangeset for help on using the changeset viewer.